[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 3/3] xen/arm: Warn user on cpu errata 832075


  • To: George Dunlap <george.dunlap@xxxxxxxxxx>
  • From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Date: Wed, 28 Oct 2020 09:56:45 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NQy8RBFw2JBcBUXvdwM4B3SFU81pp2y+IG4/qPH+uOU=; b=kB20Ar0r5DNQNnV2jvmQW41el3l5FyEQxXVXt/AQ4KYRc063pQU+Au5DHzA7Chkq8oYiQQScOrX4BKxRtHKMTrIxd1b8TpFs0SSjVNHLyUwwNWmg9T30eIaexO+SGbxiYXHBiqhse0LkbiDf/p45o3ss9FfK6wV6BhBWFTlUvnO64I+UwW4s3biJoDX9oRU/8U865YQpgppBk5fw+4TzJoHODgq+3B1OtXCena4rhs8+s5W+D0ZyYZr3C4s3a7bCU3Vq6uh0+T9rFjz0IP/wpeo7i1b6tqsSioknoGm28WhI8FNHi+Oj1zGrmLGcfaTmCfMyFqGS2B96DKZ5ecy0XA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X0qmTShFtRd0YTFv1O/quisql4IgNUlMgqRucPvO0TUueebusQJAGAeGxzAWeKWlwHAC6AD/EVmLZjluvvMQWcIGnDBSuqNQplfPQWFUNix+KP4ofUCVtm/eusOYL9yQI7E8+lRnhfkWDCrTQ4Q4JA23bbl/mK7CSMhWPuiixvZLep34cBidFwObbX8noexoos5x20iQEQiD+hFxTg/yYMseNpfdFjpxXSxZYMKKv9KEu+ttksfNJvwhULucX//dM2BdWtjhkHzPDbj+ni8jgeRTRbJGUOdU2Wjqpb7CXfCpddkfzxIuFdx7/4K3peUSKQk7UrMHJlwQIqvqApSwWA==
  • Authentication-results-original: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, "open list:X86" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Wed, 28 Oct 2020 09:57:34 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHWq7RKM3lRt4XRXUWYGPT9/eCkOKmsDfmAgACnfwCAABCqgIAAA70A
  • Thread-topic: [PATCH v2 3/3] xen/arm: Warn user on cpu errata 832075

Hi George,

> On 28 Oct 2020, at 09:43, George Dunlap <george.dunlap@xxxxxxxxxx> wrote:
> 
> 
> 
>> On Oct 28, 2020, at 8:43 AM, Bertrand Marquis <Bertrand.Marquis@xxxxxxx> 
>> wrote:
>> 
>> 
>> 
>>> On 27 Oct 2020, at 22:44, Stefano Stabellini <sstabellini@xxxxxxxxxx> wrote:
>>> 
>>> On Mon, 26 Oct 2020, Bertrand Marquis wrote:
>>>> When a Cortex A57 processor is affected by CPU errata 832075, a guest
>>>> not implementing the workaround for it could deadlock the system.
>>>> Add a warning during boot informing the user that only trusted guests
>>>> should be executed on the system.
>>>> An equivalent warning is already given to the user by KVM on cores
>>>> affected by this errata.
>>>> 
>>>> Also taint the hypervisor as unsecure when this errata applies and
>>>> mention Cortex A57 r0p0 - r1p2 as not security supported in SUPPORT.md
>>>> 
>>>> Signed-off-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
>>>> ---
>>>> SUPPORT.md               |  1 +
>>>> xen/arch/arm/cpuerrata.c | 13 +++++++++++++
>>>> 2 files changed, 14 insertions(+)
>>>> 
>>>> diff --git a/SUPPORT.md b/SUPPORT.md
>>>> index 5fbe5fc444..f7a3b046b0 100644
>>>> --- a/SUPPORT.md
>>>> +++ b/SUPPORT.md
>>>> @@ -38,6 +38,7 @@ supported in this document.
>>>> ### ARM v8
>>>> 
>>>>   Status: Supported
>>>> +    Status, Cortex A57 r0p0 - r1p2, not security supported (Errata 832075)
> 
> I think this should be:
> 
> 8<—
> 
>    Status, Cortex A57 r0p0-r1p1: Supported, not security supported
> 
> For the Cortex A57 r0p0 - r1p1, see Errata 832075.
> 
> —>8
> 

Ok I will fix that.

Thanks for the review

Cheers
Bertrand

> -George


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.