[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/5] xen/events: only register debug interrupt for 2-level events
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Jürgen Groß <jgross@xxxxxxxx>
- Date: Thu, 22 Oct 2020 15:09:04 +0200
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, x86@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>
- Delivery-date: Thu, 22 Oct 2020 13:09:12 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 22.10.20 12:35, Jan Beulich wrote:
On 22.10.2020 11:49, Juergen Gross wrote:
@@ -2080,10 +2080,12 @@ void __init xen_init_IRQ(void)
int ret = -EINVAL;
evtchn_port_t evtchn;
- if (fifo_events)
+ if (xen_fifo_events)
ret = xen_evtchn_fifo_init();
- if (ret < 0)
+ if (ret < 0) {
xen_evtchn_2l_init();
+ xen_fifo_events = false;
+ }
Another note: While it may not matter right here, maybe better
first set the variable and the call the function?
I don't think this is really important, TBH.
This code is executed before other cpus are up and we'd have major
other problems in case the sequence would really matter here.
Juergen
|
