Re: [PATCH v3] xen/rpi4: implement watchdog-based reset

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Fri, 9 Oct 2020, Bertrand Marquis wrote:
> > On 8 Oct 2020, at 19:27, Stefano Stabellini <sstabellini@xxxxxxxxxx> wrote:
> > 
> > On Thu, 8 Oct 2020, Bertrand Marquis wrote:
> >>> On 7 Oct 2020, at 23:38, Stefano Stabellini <sstabellini@xxxxxxxxxx> 
> >>> wrote:
> >>> 
> >>> The preferred method to reboot RPi4 is PSCI. If it is not available,
> >>> touching the watchdog is required to be able to reboot the board.
> >>> 
> >>> The implementation is based on
> >>> drivers/watchdog/bcm2835_wdt.c:__bcm2835_restart in Linux v5.9-rc7.
> >>> 
> >>> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
> >>> Acked-by: Julien Grall <jgrall@xxxxxxxxxx>
> >> 
> >> Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
> >> 
> >> Maybe a printk if reset was not successful ?
> > 
> > That not quite platform specific but we could add a printk to
> > xen/arch/arm/shutdown.c:machine_restart if we are still alive after
> > 100ms.
> 
> Even nicer :-)
> Definitely usefull to see something if for one reason reset/restart did
> not succeed for whatever reason.
> 
> > 
> > I'll commit this patch as is and maybe send another one for
> > machine_restart.
> 
> Please tell me if you want me to handle that one (at the end I did request
> that so not really fare to ask you to do it:-) ).

Since you are volunteering, yes please :-)