Re: [PATCH V1 01/16] x86/ioreq: Prepare IOREQ feature for making it common

[Oleksandr <olekstysh@xxxxxxxxx>]

On 23.09.20 20:22, Julien Grall wrote:
> Hi,
Hi Julien


> On 10/09/2020 21:21, Oleksandr Tyshchenko wrote:
> > From: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
> >
> > As a lot of x86 code can be re-used on Arm later on, this patch
> > prepares IOREQ support before moving to the common code. This way
> > we will get almost a verbatim copy for a code movement.
> FWIW, I agree with Jan that we need more details what and why you are 
> going it. It would be worth considering to split in smaller patch.
ok


> > This support is going to be used on Arm to be able run device
> > emulator outside of Xen hypervisor.
> >
> > Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
> Usually the first signed-off is the author of the patch. However, this 
> patch look quite far off from what I originally wrote.
> So I don't feel my signed-off-by is actually warrant here. If you want 
> to credit me, then you can mention it in the commit message.
This is related to all patches is this series. This patch series is the 
second attempt (the first was RFC) to make IOREQ support common and it 
became quite different from the initial commit.
I am sorry, I got completely lost whether the particular patch in this 
series is close to what you originally wrote or far from, I mean whether 
I should retain your SoB and whether I should drop it. So in order *not 
to make a mistake* is such an important question, I decided to add your 
SoB to each patch in this series and also add a note to each patch 
describing where this series came from.

> > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
> Cheers,
--
Regards,

Oleksandr Tyshchenko