[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH V1 04/16] xen/ioreq: Provide alias for the handle_mmio()




On 14.09.20 18:10, Jan Beulich wrote:

Hi Jan

On 10.09.2020 22:21, Oleksandr Tyshchenko wrote:
--- a/xen/common/ioreq.c
+++ b/xen/common/ioreq.c
@@ -189,7 +189,7 @@ bool handle_hvm_io_completion(struct vcpu *v)
          break;
case HVMIO_mmio_completion:
-        return handle_mmio();
+        return ioreq_handle_complete_mmio();
Again the question: Any particular reason to have "handle" in here?

"Handle" has been already discussed in previous patches). Will remove.


With the abstraction simply named ioreq_complete_mmio() feel free
to add
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>


Thank you.

--
Regards,

Oleksandr Tyshchenko




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.