[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH 5/5] sched/arinc653: Implement CAST-32A multicore scheduling


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Jeff Kubascik <Jeff.Kubascik@xxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Stewart Hildebrand <Stewart.Hildebrand@xxxxxxxxxxxxxxx>
  • Date: Thu, 17 Sep 2020 14:57:08 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=dornerworks.com; dmarc=pass action=none header.from=dornerworks.com; dkim=pass header.d=dornerworks.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector5401; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JgvPIBKTA1q9TYRrRuAx0tr4kSYnYsZKfYeOqQAkcn0=; b=dxs26SgnmKZXn6vMNAsJBrj0YfCwHrIDwrc3Gxw/7qvGy5yILE6D3eIOy1F7+eWyfqr5oS3pspfcDlnyaOrcchRtgrkn5EANHLR/KABng9LbNHIab97iywyyo/2jViUCK3m2I/NM/GS9jbVnKWhaWn/z/mOFQORtke4LojPU3RJ9usmCgKYkqHCaTpubgV57NoW4krFuvzPWrgAGKvs/F6ws4podRK5FRfWJx2FjQkc1StvvURHuxFcuZ0Uxsptl5vq/o/cP5ou2iPhcrZYQxR/Xp5HO5F+36Dc1beZzDQj081wwvb1gJmsL6UIReU526cPnsHU/6t88B0PTHDtqWg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector5401; d=microsoft.com; cv=none; b=cTYATzgwxNTT7BOQ2wi9NuLHSLvskvPEsQTZFDcUCNIAOg48vxAo/nJrC8ng08kaLtVjSXK6IzIIYC9NkQbCiNcFwGiyg5RlXA/wbWy6SwAyBw6BMzr3KMxNKBzedD/NhVDwq1qZtTR6D47MpB8ZcuMpmy7QFZRfdxTTfh0HJddZIML++F8OaF7xTxHvQrhJM8I+Kc62ZJBC+WSd2bcSNYAh2ppmutsY9Bm0U3PjTgN5YPyvVC5LindJVB9la6x2w1q1mee6e0cBpfSRWJVmcFLZUGqV9logX9u7MiUa03DRz6iH+tOHUbkM0ZZa+r9KAebMWKP/767owwHjvO+rDA==
  • Authentication-results: citrix.com; dkim=none (message not signed) header.d=none; citrix.com; dmarc=none action=none header.from=dornerworks.com;
  • Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxx>, Josh Whitehead <Josh.Whitehead@xxxxxxxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>
  • Delivery-date: Thu, 17 Sep 2020 14:57:23 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHWjFXo8LfVF1vuZEGd+q7v79upsqls6PEAgAAAqMA=
  • Thread-topic: [PATCH 5/5] sched/arinc653: Implement CAST-32A multicore scheduling

On Thursday, September 17, 2020 10:43 AM, Andrew Cooper wrote:
>On 16/09/2020 19:18, Jeff Kubascik wrote:
>> +/*
>> + * A handle with all zeros represents domain 0 if present, otherwise idle 
>> UNIT
>> + */
>> +#define DOM0_HANDLE ((const xen_domain_handle_t){0})
>
>This isn't accurate.
>
>There are systems where dom0 doesn't have a zero UUID (XenServer for
>one), and its easy to create domU's which have a zero UUID.  They are
>not unique, and can be changed at any time during the running of the VM.
>
>If you need a unique identifier, then use domid's.
>
>I can't see any legitimate need for the scheduler to handle the UUID at all.

We tried switching it to domid at one point in the past, but the problem was 
that when a domU reboots (destroy/create) the domid increments, so the schedule 
would have to be reinstantiated. At least that was the case before a recent 
patch series allowing to specify domid [1], but Jeff developed this CAST-32A 
series prior to that. The UUID can be specified in the .cfg file, allowing 
domUs to reboot and come back up with the same UUID.

Stew

[1] https://lists.xenproject.org/archives/html/xen-devel/2020-02/msg01574.html

>~Andrew

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.