Re: [PATCH 4/5] sched/arinc653: Reorganize function definition order

[Jan Beulich <jbeulich@xxxxxxxx>]

On 16.09.2020 20:18, Jeff Kubascik wrote:
> @@ -517,27 +516,35 @@ static const struct scheduler sched_arinc653_def = {
>      .sched_id       = XEN_SCHEDULER_ARINC653,
>      .sched_data     = NULL,
>  
> +    .global_init    = NULL,
>      .init           = a653sched_init,
>      .deinit         = a653sched_deinit,
>  
> -    .free_udata     = a653sched_free_udata,
> -    .alloc_udata    = a653sched_alloc_udata,
> +    .alloc_pdata    = NULL,
> +    .switch_sched   = a653sched_switch_sched,
> +    .deinit_pdata   = NULL,
> +    .free_pdata     = NULL,
>  
> +    .alloc_domdata  = NULL,
> +    .free_domdata   = NULL,
> +
> +    .alloc_udata    = a653sched_alloc_udata,
>      .insert_unit    = NULL,
>      .remove_unit    = NULL,
> +    .free_udata     = a653sched_free_udata,
>  
>      .sleep          = a653sched_unit_sleep,
>      .wake           = a653sched_unit_wake,
>      .yield          = NULL,
>      .context_saved  = NULL,
>  
> -    .do_schedule    = a653sched_do_schedule,
> -
>      .pick_resource  = a653sched_pick_resource,
> +    .migrate        = NULL,
>  
> -    .switch_sched   = a653sched_switch_sched,
> +    .do_schedule    = a653sched_do_schedule,
>  
>      .adjust         = NULL,
> +    .adjust_affinity= NULL,

Adding all these not really needed NULL initializers looks to rather move
this scheduler away from all the others. (Oddly enough all of them
explicitly set .sched_data to NULL - for whatever reason.)

Jan