[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] x86/pv: Drop assertions from svm_load_segs()


  • To: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Tue, 8 Sep 2020 11:08:03 +0100
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Tue, 08 Sep 2020 10:08:29 +0000
  • Ironport-sdr: odNgjWrvV6U28UxiSiOop/e7gaPprsYCaAFtxs3x4mzaXfzE+vakdN9TWHWiRVnXentd/ftH7R P2rznc4ANqT6W8V1VXE5u1Qs8ksGtW3qnC11a7m0WBZbgvTWHByPT8xyKLbPYFALIb8UFGkI21 l3okltkCsxGpQ7YVlY6Cw1tYyg0kuohjVJpyH+FQkQUEM/5rNAl5bjCArOYRw3qqgycfYBoASZ UKev2Rmw3i/PjHAbHYBjeup8TCNjn94Sx/goX5cM4CyxVCOiXf7r6XQdCbF3otDR1prxdYLdJD hkI=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

OSSTest has shown an assertion failure:
http://logs.test-lab.xenproject.org/osstest/logs/153906/test-xtf-amd64-amd64-1/serial-rimava1.log

These assertions were never appropriate, as they rule out legal (and, as it
turns out, sensible perf-wise) inputs based on an expectation of how the sole
caller would behave.

Fixes: ad0fd291c5 ("x86/pv: Rewrite segment context switching from scratch")
---
CC: Jan Beulich <JBeulich@xxxxxxxx>
CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
CC: Wei Liu <wl@xxxxxxx>
---
 xen/arch/x86/hvm/svm/svm.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c
index af584ff5d1..eaacbcb668 100644
--- a/xen/arch/x86/hvm/svm/svm.c
+++ b/xen/arch/x86/hvm/svm/svm.c
@@ -1559,13 +1559,11 @@ bool svm_load_segs(unsigned int ldt_ents, unsigned long 
ldt_base,
         vmcb->ldtr.base = ldt_base;
     }
 
-    ASSERT(!(fs_sel & ~3));
     vmcb->fs.sel = fs_sel;
     vmcb->fs.attr = 0;
     vmcb->fs.limit = 0;
     vmcb->fs.base = fs_base;
 
-    ASSERT(!(gs_sel & ~3));
     vmcb->gs.sel = gs_sel;
     vmcb->gs.attr = 0;
     vmcb->gs.limit = 0;
-- 
2.11.0




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.