[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Continuing the Gitlab experiment: Single-patch PRs for gitlab
- To: George Dunlap <george.dunlap@xxxxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Fri, 4 Sep 2020 10:56:03 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=21JxvkH47vBD89OzEuOImPAsXAXLHcVJa8sWol1TPgY=; b=nJqsiS8sEsHXLj39fnl5411X0TpI6ujruTuth7cUM7BbVSG2WoG/2v77NhffaLGo1PSIFr68rKVujJpYU5GUZw8zUJjUUmYmf8NLpARkI+mtTXhRXpNuwP0h5anW8tPzp7xeL3QszGrCRwyZghHrpJe76IIpu0HIXZfpS1zhTibYG1YJGQex1La3atfb0E8hryDwo1OJrmNF/zDHcP6Yj1EJt5FLs00z8F+mRhwUMZk2XXDX2t0RWP+/U1iA4BHEpqBaK2LnZVEMym/sFwnEKoGKg2v/64k4UeJEMCh7aP5L3hqpvW5ysYkXgxDrZ0lFwoj6JASa+auDFT4+4ExZYw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jHjq5J75aRWVhoMWNCYzXARQif2djWo1wG4iYgkT5/oZkuEkc1+XyisxyRdsQnSJKsMq55KADo9Mjh2h3/hAS7O4LRT/9yq+3JBPihmio2FY5Th2uc68l5wgTQ4z5jXBHXLvquwZuSFQ5pNug6ZCHc0p+KiGrNp/6aSrq5WePCTaCfBWldb5FDPsvT2C7zmrH8ggBe+yiKrNCPCNEUKk6Xrk7l86JCXUprTnlq2Tdoc8VLXBcRP3Ek7xunpah7B2NYp2WRTXvofahHsBzy3KJs0CLBfg9my0l3QW4cpZ2Uf8lgpB7FI9l3pd/QceqwbVTFNmiZAsxP+p/Hn41wFpHA==
- Authentication-results-original: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, "open list:X86" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 04 Sep 2020 10:56:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHWgqFQIv5YQfrx8UWhPeAs1v6hhqlYRMuAgAAGaQCAAAHFAIAAANcAgAAA44A=
- Thread-topic: Continuing the Gitlab experiment: Single-patch PRs for gitlab
> On 4 Sep 2020, at 11:52, George Dunlap <george.dunlap@xxxxxxxxxx> wrote:
>
>
>
>> On Sep 4, 2020, at 11:49 AM, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
>> wrote:
>>
>>>
>>> I tried to add a comment and that is working well
>>>
>>> Remarks from my side:
>>> - How can i ack/test/reject on this ?
>>
>> answer myself as i found the thumbs up that i have to click :-)
>
> I have a button that says “Approve” — do you not have that? Perhaps you
> don’t have the requisite permissions.
>
> But I think adding “Reviewed-by” in a comment would work just as well.
When you add a comment at the end you can say “Finish review”, maybe that one
is the “Reviewed-by”.
We might need to check if gitlab is not adding those automatically somehow.
Bertrand
>
> -George
|
