[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gitignore: Move ignores from global to subdirectories
- To: Elliott Mitchell <ehem+xen@xxxxxxx>
- From: George Dunlap <George.Dunlap@xxxxxxxxxx>
- Date: Mon, 31 Aug 2020 10:04:54 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8olG1aSPXN0+YNhhTfxab/4DXpVWGcvJc3wl0CNDic4=; b=YNYcM8vpIVvsyDz3eQkv0fVb8PWk5U6IOz0FAwV0mrNZ8NvQms9iBvQOujw0KodWKmvREbiQt67zhmsd+SGfmjKOsyFk6sFp95BorEfRSC3j8UmnezQUazEVyKBJGC+gnF1G+98VgTcjZlOeNHGGy9yju+Ctv6IaLvUhOdyjFMqcypBRxWGKF127aGHJSX0eyjNmHa8sM3P5YMMSE5P2fxBgwUGdKdj59tlFf6Lxq3mGZwqOB8XCUcvNe2AMRsZWAxFMwUI2kBtARAXhUlswab7zfbiY72XkBrgJd8heyLcnuh6mq+J55WQ7T1UlRLzu+Co27zM48PwAs3k7CETitQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ewW7YmHnnE1m4K4dP54x+JhUHfxjZ2OadL2spynPJ65gSeRbMVsCS0BpbvutxmHOfJM+ETmUI6L5+wqiKeb3AV0m9BhpFR/SjM51/+8CoGnpKY1HVBo90V3dJ1v1bujP2sDpvUy/psA4KZke4ablpCOQ46xHwADvy0iymlmcqBWxMe7mJeLtiJM4MZUH/njqdlZh6/on70e+1OO1iWnS9EoY2TpbIw2ITCBhUZxWSDjLhbLYDvWAEz8VVKH0j1nSW3U6VmncqXH3bO5c8K9DClOXfkqWMCVvKhcxVYnagEXq2/aTaz+ccKenmp4Rm05ahboxolfKGr27uwIalXN6qA==
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, "open list:X86" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, "Konrad Rzeszutek Wilk" <konrad.wilk@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
- Delivery-date: Mon, 31 Aug 2020 10:05:11 +0000
- Ironport-sdr: AJYei6fIbs1EVnLOOAt149L3AviATro4gCRodt02jF53qalIHeH+IPePjiwI1c0UvtMntoB1H5 upzCA5ajFlW70spUETCkgj2MlLmLGEqbk7/qTFrJ+3jV7KjpHBl7snVM6Ioash/eJbE3XYCXJf yXkRImOP4qqP/YGSPzoAtLMdUTfpFKiVeKAuNmSBbbb5n7L1XXypLTeUaVzgNMi6oLkswtWcHl acy/Z/48QIXrgwtp9rKWOysx/dmM0pDtbMzvcNq4jM6M4BKKkH9gG6QNXbxZIO9d43QavIT3L2 9oU=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHWfOcPoB6C2A3RQk+KKhmh29t936lNHsiAgASp5QCAADnbAA==
- Thread-topic: [PATCH] gitignore: Move ignores from global to subdirectories
> On Aug 31, 2020, at 7:37 AM, Elliott Mitchell <ehem+xen@xxxxxxx> wrote:
>
> On Fri, Aug 28, 2020 at 09:24:41AM +0200, Jan Beulich wrote:
>> On 28.08.2020 04:57, Elliott Mitchell wrote:
>>> Subdirectories which have .gitignore files should not be referenced in
>>> the global .gitignore files. Move several lines to appropriate subdirs.
>>>
>>> Signed-off-by: Elliott Mitchell <ehem+xen@xxxxxxx>
>>>
>>> ---
>>> Hopefully the commit message covers it. When moved to the subdirectories
>>> I'm using "./<file>" as otherwise any file sharing the name in a deeper
>>> subdirectory would be subject to the match.
>>
>> May I ask why this last sentence isn't part of the commit message?
>
> My thinking is it was pretty straightforward to figure out when looking.
> Not /quite/ obvious enough to avoid commenting in e-mail, but not quite
> obscure enough to have in commit message. This can go either way really.
Storing the extra paragraph in git is cheap; trying to reconstruct why someone
made a change 10 years after the fact is often difficult. Probably not worth a
re-send — it can be moved into the commit message by the committer; but if
you’re going to send v2 anyway, might as well move it in.
-George
|
