Re: [PATCH] x86: use constant flags for section .init.rodata

[Jan Beulich <jbeulich@xxxxxxxx>]

On 26.08.2020 15:51, Roger Pau Monne wrote:
> LLVM 11 complains with:
> 
> <instantiation>:1:1: error: changed section flags for .init.rodata, expected: 
> 0x2
> .pushsection .init.rodata
> ^
> <instantiation>:30:9: note: while in macro instantiation
>         entrypoint 0
>         ^
> entry.S:979:9: note: while in macro instantiation
>         .rept 256
>         ^
> 
> And:
> 
> entry.S:1015:9: error: changed section flags for .init.rodata, expected: 0x2
>         .section .init.rodata
>         ^

Another quirk, I would say. Has this been reported to them?

> Fix it by explicitly using the same flags and type in all the
> instances.

Indeed these look to be the only instances (in assembly files,
I didn't check asm()-s in C ones), with the slight exception
of the .fixup section specifications in x86_64/compat/entry.S
(where @progbits is omitted). Fair enough to establish
consistency here even without the specific issue above in mind.

> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>