[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 5/5] x86: simplify is_guest_l2_slot()

  • To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Mon, 24 Aug 2020 13:50:29 +0100
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Mon, 24 Aug 2020 12:50:38 +0000
  • Ironport-sdr: xzxmE0IdO3u53g4PXSSCZ90DAdmLblzaz9mjNX5LrlJ9lydAZi6mFXBakvECStIbQeThwuWBIu JHASEoV7SE6ExWUbfzXbJUreQLcj5/7myV8NkF3Z51OXAu6JJV2RpEslqbAwKEAxkf0vA5oX8g ztChESH2pC5Fm/oBirs//YjOGNpYdiNaVw2+s6JuI8HfR18xEpfSuD6CPrCqlnXpdLjJdiYNYM NYscJ5ifqIOrCGkokYIAVwW+keoJAOd/mqX2HgIpYTd/Cj6Kc8VDs8OqiRfu9KwoSfyW2R5SWm jpw=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24/08/2020 13:35, Jan Beulich wrote:
> is_pv_32bit_domain() has become expensive, and its use here is
> redundant: Only 32-bit guests would ever get PGT_pae_xen_l2 set on
> their L2 page table pages anyway.
>
> Suggested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Possibly "if some other error does lead to PGT_pae_xen_l2 ending up
anywhere else, we still don't want to allow a guest to control the
entries" ?

Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

 

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.

Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.