[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] drm: allow limiting the scatter list size.
- To: Christian König <christian.koenig@xxxxxxx>
- From: Gerd Hoffmann <kraxel@xxxxxxxxxx>
- Date: Tue, 18 Aug 2020 10:27:03 +0200
- Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx, David Airlie <airlied@xxxxxxxx>, "open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS" <nouveau@xxxxxxxxxxxxxxxxxxxxx>, Sandy Huang <hjc@xxxxxxxxxxxxxx>, Thierry Reding <thierry.reding@xxxxxxxxx>, Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>, "open list:RADEON and AMDGPU DRM DRIVERS" <amd-gfx@xxxxxxxxxxxxxxxxxxxxx>, Jonathan Hunter <jonathanh@xxxxxxxxxx>, "open list:ARM/Rockchip SoC support" <linux-rockchip@xxxxxxxxxxxxxxxxxxx>, Ben Skeggs <bskeggs@xxxxxxxxxx>, Russell King <linux+etnaviv@xxxxxxxxxxxxxxx>, "moderated list:DRM DRIVERS FOR XEN" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "open list:DRM DRIVER FOR MSM ADRENO GPU" <linux-arm-msm@xxxxxxxxxxxxxxx>, "moderated list:DRM DRIVERS FOR VIVANTE GPU IP" <etnaviv@xxxxxxxxxxxxxxxxxxxxx>, "open list:DRM DRIVERS FOR NVIDIA TEGRA" <linux-tegra@xxxxxxxxxxxxxxx>, Sean Paul <sean@xxxxxxxxxx>, "moderated list:ARM/Rockchip SoC support" <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, open list <linux-kernel@xxxxxxxxxxxxxxx>, Thomas Zimmermann <tzimmermann@xxxxxxx>, Alex Deucher <alexander.deucher@xxxxxxx>, "open list:DRM DRIVER FOR MSM ADRENO GPU" <freedreno@xxxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 18 Aug 2020 08:27:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Aug 18, 2020 at 09:57:59AM +0200, Christian König wrote:
> Am 18.08.20 um 09:48 schrieb Gerd Hoffmann:
> > Add max_segment argument to drm_prime_pages_to_sg(). When set pass it
> > through to the __sg_alloc_table_from_pages() call, otherwise use
> > SCATTERLIST_MAX_SEGMENT.
> >
> > Also add max_segment field to gem objects and pass it to
> > drm_prime_pages_to_sg() calls in drivers and helpers.
> >
> > Signed-off-by: Gerd Hoffmann <kraxel@xxxxxxxxxx>
>
> I'm missing an explanation why this should be useful (it certainly is).
virtio-gpu needs this to work properly with SEV (see patch 2/2 of this
series).
> And the maximum segment size seems misplaced in the GEM object. This is
> usually a property of the device or even completely constant.
Placing it in drm_device instead would indeed work for virtio-gpu, so I
guess you are suggesting that instead?
take care,
Gerd
|
