[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] arch/x86/setup.c: Ignore early boot parameters like no-real-mode


  • To: Trammell Hudson <hudson@xxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Thu, 13 Aug 2020 12:49:57 +0100
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 13 Aug 2020 11:50:25 +0000
  • Ironport-sdr: DUNXeUGO06MIRp2Tw/BGWknJp44X6Gsva2WE3NqbY+5yaCheiXiFG7qdvqpPDAiITFLG6U4Ul6 9K3Ka7HeY129/GjHneAaUDIxiiTk5KOU2saNuT+1UcFUC76kExLEoyuL96WUPrqUkVLlah2VqR MHskUxdq/7UdbwNVkjdb7pdWtXZXFhCvYbCiPIgfEax+ADjBAbdQ1dgEo1oSPDrzZGc+tt1YJP KWRH5XYC4OYba/I5Ka8T8cnpYO6aSMcSt3lpbt9TkuUc2cL78unhS/DzwlV2VYCzx6eh1MwWMo dyc=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 13/08/2020 00:35, Andrew Cooper wrote:
> On 12/08/2020 20:06, Trammell Hudson wrote:
>> On Wednesday, August 12, 2020 8:16 PM, Andrew Cooper 
>> <andrew.cooper3@xxxxxxxxxx> wrote:
>>> If you want, I can sort that out as a prereq patch, and rebase this one
>>> on top?
>> That sounds fine to me. They really are two separate patches.
> I think we're fine caveat wise.  I'll try and find some time tomorrow.

So the __UNIQUE_ID() plan doesn't work, as a consequence of the logic
inside ignore_param() to shuffle the string name into initdata.

As everything is in .initdata, it doesn't actually interact with LIVEPATCH.

I've committed this patch with an extra note to try and prevent
TEMP_NAME() being used in wider contexts.

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.