[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/7] x86/EFI: sanitize build logic


  • To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Fri, 7 Aug 2020 17:33:44 +0100
  • Authentication-results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Fri, 07 Aug 2020 16:34:10 +0000
  • Ironport-sdr: wtMOLiNMujuNa+yCG+2xE1d/W+TgArODTJtev51V8xVAEFbrnK9wjmjtGzN4kHLohU84aubPDB 9D8oVSruLAtBSi35/aGYVHE+T2DkMn2mjQO7B5uTG0kEV3VIzbWhNf4gwgKkmzKMlZwZaf9BjV R0rXwzh6jodNfCMt1ZM4C62NSp6zb/ZGsDadNCh0mVqqaAGJm/XnY9NH6dLIIA6puLH719dAhS jdptwiRU7yuvlt7hcrv02XcNsHsc1iYEAJSAGqpLQaccifWdYKOtodw00irCh/NLLNkATv5YO7 hVQ=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 07/08/2020 12:32, Jan Beulich wrote:
> With changes done over time and as far as linking goes, the only special
> thing about building with EFI support enabled is the need for the dummy
> relocations object for xen.gz uniformly in all build stages. All other
> efi/*.o can be consumed from the built_in*.o files.
>
> In efi/Makefile, besides moving relocs-dummy.o to "extra", also properly
> split between obj-y and obj-bin-y.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

I'd prefer to see this all in Kconfig, but this is a clear improvement
in its own right.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.