[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] xen/displif: Protocol version 2


  • To: Jürgen Groß <jgross@xxxxxxxx>, Oleksandr Andrushchenko <andr2000@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "ian.jackson@xxxxxxxxxxxxx" <ian.jackson@xxxxxxxxxxxxx>, "wei.liu2@xxxxxxxxxx" <wei.liu2@xxxxxxxxxx>, "konrad.wilk@xxxxxxxxxx" <konrad.wilk@xxxxxxxxxx>
  • From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
  • Date: Tue, 30 Jun 2020 06:13:12 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=61vwN2V36GBMz5mPLFU4NiZAqYGrODMeIOVzsgiE85w=; b=lMJHq0EuRi6qNpo6qCFBLXOJc2/TkGt5LtWVMHP6r7k3EpcKfWGrs+MkqffL98fBvlEQMkdgtfFO/CgppoVMroG17Z7jiW5DMStlHN7SGPMzQ/zfs8y9E7yxyPwF50AOZ1niY3RI0knvWanxDy3mIpg98Ysab3Jx9qE9i0LrHoOHCDMZpYqwvVAcMHsT86HZcVrdghXIib60HJfLN2O41Ny1tVi333xremXLSWwGYDLtCWzcMxTL7V2uNJDiXYej9kXZE8BoQIe0n9rgK/5rfc1y5ojHnW2LyLZsZG38Rjsezg86isl3t5S8/ED3G25dLQVe/EKvEB4FY1E9YxbVow==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NI+5iJI7bVggoSGXeuI2UylzrQGYOwzhAY0t+7Xj3gBd0+Oj8kwFdUC63wwdXWaMz7lctjkpG6kb3ugY6rvIlW0BQyhugTXAnBpElY8o0fepUjo8kCm/HFWDh86TZ/D2MnB3vLERUM972hKTDXrTgvwH20LbgYZySoXf97ZAv5fZ3b5jcTsF705fZctBDXYVUmBXP342m3z56YKU1qEweG3fe6BLG30+Ekhm1ZxKS+8vfSMaje4zLKc4Dc0N5whmJYzFosEz+oYkuWg2HlAEzp2qU+9tu86wuWg0mbWRVPRNKOGwAoWFt/+SrI1UD4EVrrboSJfiBQ7sV2jfwfSFPQ==
  • Authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=epam.com;
  • Delivery-date: Tue, 30 Jun 2020 06:13:25 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHWLoWtcyE1H7HtP020nOg+0Ywa4ajvaVUAgAGEr4A=
  • Thread-topic: [PATCH 1/2] xen/displif: Protocol version 2

On 6/29/20 10:02 AM, Jürgen Groß wrote:
> On 20.05.20 11:04, Oleksandr Andrushchenko wrote:
>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>>
>> 1. Change protocol version from string to integer
>>
>> Version string, which is in fact an integer, is hard to handle in the
>> code that supports different protocol versions. To simplify that
>> make the version an integer.
>>
>> 2. Pass buffer offset with XENDISPL_OP_DBUF_CREATE
>>
>> There are cases when display data buffer is created with non-zero
>> offset to the data start. Handle such cases and provide that offset
>> while creating a display buffer.
>>
>> 3. Add XENDISPL_OP_GET_EDID command
>>
>> Add an optional request for reading Extended Display Identification
>> Data (EDID) structure which allows better configuration of the
>> display connectors over the configuration set in XenStore.
>> With this change connectors may have multiple resolutions defined
>> with respect to detailed timing definitions and additional properties
>> normally provided by displays.
>>
>> If this request is not supported by the backend then visible area
>> is defined by the relevant XenStore's "resolution" property.
>>
>> If backend provides extended display identification data (EDID) with
>> XENDISPL_OP_GET_EDID request then EDID values must take precedence
>> over the resolutions defined in XenStore.
>>
>> 4. Bump protocol version to 2.
>>
>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>> ---
>>   xen/include/public/io/displif.h | 83 +++++++++++++++++++++++++++++++--
>>   1 file changed, 80 insertions(+), 3 deletions(-)
>>
>> diff --git a/xen/include/public/io/displif.h 
>> b/xen/include/public/io/displif.h
>> index cc5de9cb1f35..4d43ba5078c8 100644
>> --- a/xen/include/public/io/displif.h
>> +++ b/xen/include/public/io/displif.h
>> @@ -38,7 +38,7 @@
>>    *                           Protocol version
>> ******************************************************************************
>>    */
>> -#define XENDISPL_PROTOCOL_VERSION     "1"
>> +#define XENDISPL_PROTOCOL_VERSION     2
>
> This is not very nice regarding compatibility.
>
> Can't you add a new macro for the integer value?

We can leave it as is, e.g. define XENDISPL_PROTOCOL_VERSION as "2",

so we do not break the existing users. Then if every user of the header has

its local copy (this is what we now use in the display backend), then that
local copy can be changed in a way suitable for the concrete user, e.g. "2"

redefined to 2. This cannot be done (?) for the Linux Kernel though.

Or we can have

#define XENDISPL_PROTOCOL_VERSION     "2"

#define XENDISPL_PROTOCOL_VERSION_INT  2

Jurgen, what's your preference here?

>
> And please add comments further down which additions are related to
> the new version.
I will after the review is done and other comments are fixed
>
>
> Juergen

Thank you,

Oleksandr

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.