[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] xen/arm: Convert runstate address during hypcall
- To: Julien Grall <julien@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Mon, 15 Jun 2020 14:01:45 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=43737ITja0zBaHL08O+LOoRG3LylD7T40HDB3k4aQr8=; b=eB9/8tT/l/XnxrXY6wmT5lYPqUuRGiAcVYgsBdhKltZOggjv9rK6t3zxD5QLMBs3cYt+kgYoot7as8kHauAf/Nsv8yMFMbLMijG39hkIiVu05v9yU92W/FiwL9G5NCrMI3O0XIjsEVRN1gvBQni0k0gekRyObQMQBZK5eYpgZAffsYxrvsRJ6UChjZ4yKFP9sqS2QABW/nQxoOVHcw5Cyd9a3Rptzgx+ke1BRBYwFbCMnVqVQUxueLU1jE9kFVDU/aeMYxB0/cGE0pfvJr5FT1+b/2y23NpSBUg2IkNVHz+WFe7Zf5SixOQoUhpaCbe5xtT/UikGgG8SMQjB22yAMw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UIbT42Zj9AupHFtwWSprZhDVlnb9ddkj9H+tyvhF9vkRA7OPPqdw4j5nzGRi1gnPAFVaD1iJJbKGAiX1G27O9gU90oRTYGJfbqHAU/O26EIBWfhDY7pyjj77Poabuf+wXlQ2Ye5JoQQ/X+LfxZfvT1bzzfhNk96WbudPC82LB5/1w++JNKH5LB/ZoqY2/u4MFK0D6+XBXRfJ1a6sa26b4TpzN3sls1AMCYaUzDozBaJH7YBNxxnOp3aU9FdoTy8aRYjKEFCR3YMDymMxgxiN3GN3yybqmSRzVRVyiZVk+7vn4mv2kpeL6wfLJ4tqZBuZYJXa1GL3kSfiQ4N6pTBchw==
- Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, nd <nd@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 15 Jun 2020 14:02:03 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHWP+e0l1aGgjLKI0+XFOOVnv/iZKjUz6iAgABkF4CAAD1XAIAEShyA
- Thread-topic: [PATCH 1/2] xen/arm: Convert runstate address during hypcall
> On 12 Jun 2020, at 21:31, Julien Grall <julien@xxxxxxx> wrote:
>
>
>
> On 12/06/2020 17:51, Bertrand Marquis wrote:
>
> Hi,
>
>>>> diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
>>>> index 4e2f582006..3a7f53e13d 100644
>>>> --- a/xen/include/asm-arm/domain.h
>>>> +++ b/xen/include/asm-arm/domain.h
>>>> @@ -11,6 +11,7 @@
>>>> #include <asm/vgic.h>
>>>> #include <asm/vpl011.h>
>>>> #include <public/hvm/params.h>
>>>> +#include <public/vcpu.h>
>>>
>>> Why do you need to add this new include?
>> Sorry I forgot to answer to this one.
>> This is needed to have the definition of vcpu_register_runstate_memory_area.
>
> I might be missing something because nothing you have added this header seem
> to require vcpu_register_runstate_memory_area. So should the include be done
> in a different header?
Right.
This was required before when I had the definitions of the interface per arch
to have a static inline for x86.
This is not needed and I will remove that include.
Cheers
Bertrand
|
