[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH for-4.14] tools/libxc: Drop config_transformed parameter from xc_cpuid_set()


  • To: "paul@xxxxxxx" <paul@xxxxxxx>
  • From: Ian Jackson <ian.jackson@xxxxxxxxxx>
  • Date: Fri, 12 Jun 2020 16:53:43 +0100
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, 'Wei Liu' <wl@xxxxxxx>, 'Xen-devel' <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 12 Jun 2020 15:54:25 +0000
  • Ironport-sdr: YXrMwguBL+IgQnqDk0+ehaEcLNp0LZ5jt6xVp6hqo/xaZkWeBYdSSRXt/sg9Cj5K2Ld/6dJBR5 bMJeVWmatGTDj1Z46cEchT8IgwEQ2WR5MRCBckvvzN9B1LJRNdabRNQf+vrO4ry3ukIkfZV5HN ENcKRN/ELT1HOmWZc+GC0i0SOKDMegIY+iGW4DI/Ri04AsUaGGWnwyGXGzClpsTt3RuaQmf0nz zJCPkdLTex5/1QDAheQMzcdgiZw1GTtnx7zYXsDG3Me2tKVmZ2DFxEqAmtNg65P4VRnOk3g7Zy aO4=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Paul Durrant writes ("RE: [PATCH for-4.14] tools/libxc: Drop config_transformed 
parameter from xc_cpuid_set()"):
> > -----Original Message-----
> > From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > Sent: 12 June 2020 11:55
> > To: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
> > Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>; Ian Jackson 
> > <Ian.Jackson@xxxxxxxxxx>; Wei Liu
> > <wl@xxxxxxx>; Paul Durrant <paul@xxxxxxx>
> > Subject: [PATCH for-4.14] tools/libxc: Drop config_transformed parameter 
> > from xc_cpuid_set()
> > 
> > libxl is now the sole caller of xc_cpuid_set().  The config_transformed 
> > output
> > is ignored, and this patch trivially highlights the resulting memory leak.
> > 
> > "transformed" config is now properly forwarded on migrate as part of the
> > general VM state, so delete the transformation logic completely, rather than
> > trying to adjust just libxl to avoid leaking memory.
> > 
> > Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> 
> Reviewed-by: Paul Durrant <paul@xxxxxxx>
> Release-acked-by: Paul Durrant <paul@xxxxxxx>

Reviewed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

I will commit this in a moment.

Ian.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.