[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: libxl dirty in tree after libxl build


  • To: "paul@xxxxxxx" <paul@xxxxxxx>
  • From: Ian Jackson <ian.jackson@xxxxxxxxxx>
  • Date: Fri, 12 Jun 2020 16:13:17 +0100
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, 'Wei Liu' <wl@xxxxxxx>, 'xen-devel' <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 12 Jun 2020 15:13:47 +0000
  • Ironport-sdr: hg0iaBBxuQ4i8AxbsjU5IFy1cI7sh2Kv4FRJgEUOcw+gJ2VtQQNAHVcgIFiSg/aXsSmaAc+j+F 1eeGOxW7Kax9panAOEqii458R1+vajk49OXdzG3IbGm7o7xWF9QU3cTGbggc+2gBKZcU9hnbB7 518l4/ZYnyrUpwSSuMIeX/seegu9myAKGlKlqHlzyVbbzm0mCPVl5Oya99tU9WLU70XNmWkUvq cTXo7kybf7Tppw71Qv2GVgzJH2snohYc6LqssEJvGzzHO54NMDgSsCEtXXdMBxy6+IsqsvLd+G lZk=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Paul Durrant writes ("RE: libxl dirty in tree after libxl build"):
> Can't we check in a file with a different name 'e.g.' with something
> like '.tmpl' on the end, which we copy into place in case the
> flex/bison don't generate such a file? That way the checked in file
> never gets dirtied.

That would be possible in principle.  It would be necessary to do
something fiddly in the Makefile runes to make sure that the build
failed if you updated the input files but didn't have flex/bison.

Another alterntaive, of course, would be to say that we don't support
such ancient versions of flex/bison, or systems without those tools at
all, and simply delete the generated files.  I forget the details but
the relevant changes were released upstream at least a decade ago.

But I think that at this stage of the release it would be best to
update the files as has been our practice hitherto.  I am not keen on
the idea of inventing new weird Makefile wrinkles during the freeze,
unless we have no reasonable alternative.

Patches will follow in a moment.

Ian.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.