[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/boot: use BASEDIR for include path


  • To: Bertrand Marquis <bertrand.marquis@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Thu, 11 Jun 2020 17:24:40 +0100
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: nd@xxxxxxx, Wei Liu <wl@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Thu, 11 Jun 2020 16:24:55 +0000
  • Ironport-sdr: tovZV+l39RiBDrBJJGwxu3BCEAirlTXlvnO4jTfDXJ9Qy+ln2QMsm74hjZ6sNd9yR3jlpJMQBO pJsMH9jMauN0kxNZp9eQhiWtAeqLxdwnX3uC9NudbPklAtW18ZS3xTr4FYD6Nu5Mc7oWwuIBGK jLHnrVN8jcIjt0/pVZR0c1XYAB/VPSG0Eka5E1HttgDvnVTdIXJq+KB1ZyF/GFe7fpSZxpYb+D odKapN6xmU9acSKDSXbMGJeUhRLzn2ROjZaZkFl4fPQH0MFYnHAujKvJfhcFETfp2dCB6/Epge inU=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 11/06/2020 12:54, Bertrand Marquis wrote:
> Use $(BASEDIR)/include instead of $(XEN_ROOT)/xen/include for the
> include path to be coherent with the rest of the Makefiles.
>
> Signed-off-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>

Does something subtle break before this change?

~Andrew

> ---
>  xen/arch/x86/boot/build32.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/x86/boot/build32.mk b/xen/arch/x86/boot/build32.mk
> index 5851ebff5f..8cd5403926 100644
> --- a/xen/arch/x86/boot/build32.mk
> +++ b/xen/arch/x86/boot/build32.mk
> @@ -5,7 +5,7 @@ include $(XEN_ROOT)/Config.mk
>  $(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS))
>  
>  CFLAGS += -Werror -fno-builtin -g0 -msoft-float
> -CFLAGS += -I$(XEN_ROOT)/xen/include
> +CFLAGS += -I$(BASEDIR)/include
>  CFLAGS := $(filter-out -flto,$(CFLAGS)) 
>  
>  # NB. awk invocation is a portable alternative to 'head -n -1'




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.