RE: [PATCH] libacpi: Widen TPM detection

[Paul Durrant <xadimgnik@xxxxxxxxx>]

> -----Original Message-----
> From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Sent: 11 June 2020 12:52
> To: Jason Andryuk <jandryuk@xxxxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>; Wei Liu <wl@xxxxxxx>; Jan 
> Beulich <jbeulich@xxxxxxxx>;
> Paul Durrant <paul@xxxxxxx>
> Subject: Re: [PATCH] libacpi: Widen TPM detection
> 
> On 11/06/2020 04:55, Jason Andryuk wrote:
> > The hardcoded tpm_signature is too restrictive to detect many TPMs.  For
> > instance, it doesn't accept a QEMU emulated TPM (VID 0x1014 DID 0x0001).
> > Make the TPM detection match that in rombios which accepts a wider
> > range.
> >
> > With this change, the TPM's TCPA ACPI table is generated and the guest
> > OS can automatically load the tpm_tis driver.  It also allows seabios to
> > detect and use the TPM.  However, seabios skips some TPM initialization
> > when running under Xen, so it will not populate any PCRs unless modified
> > to run the initialization under Xen.
> >
> > Signed-off-by: Jason Andryuk <jandryuk@xxxxxxxxx>
> 
> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> 
> This looks like it wants backporting, so CC'ing Paul for a 4.14 release ack.

Agreed.

Release-acked-by: Paul Durrant <paul@xxxxxxx>