[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 00/35] hw/qdev: Warn when using pre-qdev/QOM devices
- To: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>, Peter Maydell <peter.maydell@xxxxxxxxxx>
- From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
- Date: Tue, 9 Jun 2020 13:14:43 +0200
- Cc: Sagar Karandikar <sagark@xxxxxxxxxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Mark Cave-Ayland <mark.cave-ayland@xxxxxxxxxxxx>, QEMU Developers <qemu-devel@xxxxxxxxxx>, Max Filippov <jcmvbkbc@xxxxxxxxx>, Alistair Francis <Alistair.Francis@xxxxxxx>, Gerd Hoffmann <kraxel@xxxxxxxxxx>, "Edgar E. Iglesias" <edgar.iglesias@xxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Magnus Damm <magnus.damm@xxxxxxxxx>, Markus Armbruster <armbru@xxxxxxxxxx>, Marcel Apfelbaum <marcel.apfelbaum@xxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>, David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>, Andrzej Zaborowski <balrogg@xxxxxxxxx>, Eduardo Habkost <ehabkost@xxxxxxxxxx>, Alistair Francis <alistair@xxxxxxxxxxxxx>, qemu-arm <qemu-arm@xxxxxxxxxx>, "open list:X86" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "open list:RISC-V" <qemu-riscv@xxxxxxxxxx>, Stafford Horne <shorne@xxxxxxxxx>, Palmer Dabbelt <palmer@xxxxxxxxxxx>, Richard Henderson <rth@xxxxxxxxxxx>, "Daniel P . Berrange" <berrange@xxxxxxxxxx>, Thomas Huth <huth@xxxxxxxxxxxxx>, Bastian Koppelmann <kbastian@xxxxxxxxxxxxxxxxxxxxx>, Michael Walle <michael@xxxxxxxx>, qemu-ppc <qemu-ppc@xxxxxxxxxx>, Aurelien Jarno <aurelien@xxxxxxxxxxx>
- Delivery-date: Tue, 09 Jun 2020 11:15:55 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 08/06/20 18:17, Philippe Mathieu-Daudé wrote:
> On 6/8/20 6:14 PM, Peter Maydell wrote:
>> On Mon, 8 Jun 2020 at 17:00, Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
>> wrote:
>>>
>>> Based on today's IRC chat, this is a trivial RFC series
>>> to anotate pre-qdev/QOM devices so developers using them
>>> without knowing they are not QOM'ified yet can realize
>>> it and convert them if they have time.
>>
>> What mechanism did you use for identifying non-QOM devices?
>
> I don't think this is the complete list, this is only all the one I
> could find with:
>
> $ git grep "g_new|g_malloc" hw/
>
> Then on each match I manually reviewed (so I might have incorrectly
> flagged code too).
Yes, you did, but I guess for an RFC it was a good bang for the buck. I
went through the patch and noticed both a few false positives and a
couple blatant violations in recent code.
Paolo
|
