Re: 4.14.0-rc1 blocked on goland build failure - decision needed

[George Dunlap <George.Dunlap@xxxxxxxxxx>]

> On Jun 8, 2020, at 3:48 PM, Ian Jackson <ian.jackson@xxxxxxxxxx> wrote:
> 
> Ian Jackson writes ("4.14.0-rc1 blocked on goland build failure - decision 
> needed"):
>> Hi, Paul.  For those on xen-devel: context is that Paul asked me to
>> cut 4.14.0-rc1.  The checklist asks me to perform a test build.
>> 
>> My 32-bit tools test build failed.  I think the problem is probably
>> specific to 32-bit userland on 64-bit Linux kernel.  I will send a
>> second followup mail not CC Paul with technical details.
> 
> Technical details@:
> 
> The first error looks like this:
> 
> ./helpers.gen.go:901[/tmp/go-build643158686/_/u/iwj/work/xen.git/tools/golang/xenlight/_obj/helpers.gen.cgo1.go:1172]:
> type [268435456]_Ctype_struct_libxl_sched_params larger than address
> space

Actually, I don’t think this has anything to do with 32-bit userspace, but 
instead has to do with the version of go: The version in stretch is 1.7 and 
chokes on this for some reason.  I haven’t had time to track down why.  It does 
work for golang 1.11.

Options are:

1. Document that if you have a version of golang older than 1.11, you need to 
add `—disable-golang` 

2. Modify configure to check for the go version, and only enable if the version 
is > 1.11

3. Try to root-cause the issue.

I’m inclined to say we should go with #1 for this RC, then either #2 or #3.

 -George