[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 03/11] swiotlb-xen: add struct device* parameter to xen_phys_to_bus

To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 8 Jun 2020 00:05:07 -0700
Cc: jgross@xxxxxxxx, tamas@xxxxxxxxxxxxx, konrad.wilk@xxxxxxxxxx, roman@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, boris.ostrovsky@xxxxxxxxxx, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
Delivery-date: Mon, 08 Jun 2020 07:05:18 +0000
List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Wed, Jun 03, 2020 at 03:22:39PM -0700, Stefano Stabellini wrote:
> From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
> 
> The parameter is unused in this patch.
> No functional changes.

This looks weird.  I'm pretty sure you are going to use it later, but
why not just add the argument when it actually is used?

Follow-Ups:
- Re: [PATCH v2 03/11] swiotlb-xen: add struct device* parameter to xen_phys_to_bus
  - From: Stefano Stabellini

References:
- [PATCH v2 00/11] fix swiotlb-xen for RPi4
  - From: Stefano Stabellini
- [PATCH v2 03/11] swiotlb-xen: add struct device* parameter to xen_phys_to_bus
  - From: Stefano Stabellini

Prev by Date: Re: [PATCH v2 01/11] swiotlb-xen: use vmalloc_to_page on vmalloc virt addresses
Next by Date: Re: [PATCH v2 04/11] swiotlb-xen: add struct device* parameter to xen_bus_to_phys
Previous by thread: [PATCH v2 03/11] swiotlb-xen: add struct device* parameter to xen_phys_to_bus
Next by thread: Re: [PATCH v2 03/11] swiotlb-xen: add struct device* parameter to xen_phys_to_bus
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.