[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v2 1/5] libxl: Generate golang bindings in libxl Makefile



> The simplest short-term way to fix this would be to remove the `go fmt` call 
> from `gengotypes.py`.  It’s actually relatively unusual for generated code to 
> look pretty (or even be looked at).  We could also consider adding in some 
> “manual” formatting in gengotypes.py, like indentation, so that it doesn’t 
> look too terrible.
> 
> Nick, do you have time to work on a patch like that?

Yes, I have time to work on a quick patch for this. I'll see what it
would take to add a bit of basic manual formatting, but of course the
original purpose of using gofmt was to avoid re-creating formatting
logic. I'll likely just remove the call to go fmt.

Out of curiosity, would it be totally out of the question to require
having gofmt installed (not for 4.14, but in the future)? I ask because
I haven't seen it discussed one way or the other.

Thanks,
-NR



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.