[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [[PATCH v2 for-4.14]] m4: use test instead of []


  • To: Wei Liu <wl@xxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Tue, 2 Jun 2020 11:59:44 +0200
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Xen Development List <xen-devel@xxxxxxxxxxxxxxxxxxxx>, paul@xxxxxxx, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Delivery-date: Tue, 02 Jun 2020 10:00:20 +0000
  • Ironport-sdr: d2Mu1LQtWWzeflpB18rpXYYVCxEvmvsmgsp/f2Lnpo5NKs3sdUyh4idN4VlKV1ycu5slUKKX1n TKLMTKpnhcp3HfjlB0IcJ8G1ZNKtfxj2VhPwf9nLzxrqWiVNM/3O1ktRB8YbhdaPky+Vg7Z6K2 jvRSdE8LO9a7iDggTjqiEdkcFT4ZHB+jwbPL6yUfitL0baH/GKNrdRdsshgumvbnTEUnYM4qql sgMvbZFBvKLF88mxuZoLDQT8aasDWXN4Cuf1DJIQJAqJQYiUGGpzGN0lsCBRekpqa2dJn506MH pnI=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

There's a double [] enclosure in the subject

On Tue, Jun 02, 2020 at 09:01:38AM +0000, Wei Liu wrote:
> It is reported that [] was removed by autoconf, which caused the
> following error:
> 
>   ./configure: line 4681: -z: command not found
> 
> Switch to test. That's what is used throughout our configure scripts.
> Also put the variable expansion in quotes.
> 
> Signed-off-by: Wei Liu <wl@xxxxxxx>
> Reported-by: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
> Fixes: 8a6b1665d987 ("configure: also add EXTRA_PREFIX to {CPP/LD}FLAGS")
> Signed-off-by: Wei Liu <wl@xxxxxxx>

There's a double SoB ;)

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks for taking care of this.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.