Re: [PATCH 7/8] hw/i386/xen/xen-hvm: Use the IEC binary prefix definitions

[Philippe Mathieu-Daudé <f4bug@xxxxxxxxx>]

On 6/1/20 9:26 AM, Paul Durrant wrote:
>> -----Original Message-----
>> From: Philippe Mathieu-Daudé <philippe.mathieu.daude@xxxxxxxxx> On Behalf Of 
>> Philippe Mathieu-Daudé
>> Sent: 31 May 2020 18:38
>> To: qemu-devel@xxxxxxxxxx
>> Cc: Andrew Jeffery <andrew@xxxxxxxx>; Helge Deller <deller@xxxxxx>; Peter 
>> Maydell
>> <peter.maydell@xxxxxxxxxx>; Richard Henderson <rth@xxxxxxxxxxx>; Eduardo 
>> Habkost
>> <ehabkost@xxxxxxxxxx>; Paul Durrant <paul@xxxxxxx>; Hervé Poussineau 
>> <hpoussin@xxxxxxxxxxx>; Marcel
>> Apfelbaum <marcel.apfelbaum@xxxxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx; 
>> Paolo Bonzini
>> <pbonzini@xxxxxxxxxx>; Stefano Stabellini <sstabellini@xxxxxxxxxx>; Cédric 
>> Le Goater <clg@xxxxxxxx>;
>> qemu-trivial@xxxxxxxxxx; Joel Stanley <joel@xxxxxxxxx>; qemu-arm@xxxxxxxxxx; 
>> Michael S. Tsirkin
>> <mst@xxxxxxxxxx>; Anthony Perard <anthony.perard@xxxxxxxxxx>; 
>> qemu-ppc@xxxxxxxxxx; Philippe Mathieu-
>> Daudé <f4bug@xxxxxxxxx>
>> Subject: [PATCH 7/8] hw/i386/xen/xen-hvm: Use the IEC binary prefix 
>> definitions
>>
>> IEC binary prefixes ease code review: the unit is explicit.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@xxxxxxxxx>
>> ---
>>  hw/i386/xen/xen-hvm.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c
>> index 82ece6b9e7..679d74e6a3 100644
>> --- a/hw/i386/xen/xen-hvm.c
>> +++ b/hw/i386/xen/xen-hvm.c
>> @@ -9,6 +9,7 @@
>>   */
>>
>>  #include "qemu/osdep.h"
>> +#include "qemu/units.h"
>>
>>  #include "cpu.h"
>>  #include "hw/pci/pci.h"
>> @@ -230,7 +231,7 @@ static void xen_ram_init(PCMachineState *pcms,
>>           * Xen does not allocate the memory continuously, it keeps a
>>           * hole of the size computed above or passed in.
>>           */
>> -        block_len = (1ULL << 32) + x86ms->above_4g_mem_size;
>> +        block_len = 4 * GiB + x86ms->above_4g_mem_size;
> 
> Not strictly necessary but could we retain the brackets please?

Sure.

Laurent, if this can go via your trivial@ tree, can you do the change or
you rather I resend the whole series?

> 
>   Paul
> 
>>      }
>>      memory_region_init_ram(&ram_memory, NULL, "xen.ram", block_len,
>>                             &error_fatal);
>> --
>> 2.21.3
> 
> 
>