[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 17/20] tools/libx[cl]: Plumb static_data_done() up into libxl

  • To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
  • From: Ian Jackson <ian.jackson@xxxxxxxxxx>
  • Date: Fri, 29 May 2020 16:58:47 +0100
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Anthony Perard <anthony.perard@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Fri, 29 May 2020 15:59:00 +0000
  • Ironport-sdr: GPUUh8qB2JwxVxteQ8OryyBqIJynNY/kZSfgGZNZlMbo1aAGACI4TpWS2zeErxjkyWFj6N9+3o b752A+WkWkoD78hFcpZZKgNow0XvZx2jvNPfcwAuape1wLYXxYP/FlhIYzW9IOdhrRvRD0SpS+ 0FoZ6Jx2rPhrKsF5AzEeBES8MfU3+LZlLBIrqzcP+3rARGIlpcbXTZyteminyKksxRtTY5bGI7 Bk2qbHDMM4yoW0A1IfPoGC/icXKQeZY9uN6S0IIlhvs08XHuXUO20WhZvwgHpXgNQiZT1iG+Da Dyo=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Andrew Cooper writes ("Re: [PATCH 17/20] tools/libx[cl]: Plumb 
static_data_done() up into libxl"):
> There are several things going on here.
> One is the control flow marker of "We reached the end of the static
> data".  A higher level toolstack needs to know this unconditionally,
> which is why the callback is mandatory.
> For v2 compatibility, its callers cope with "this is where an end of
> static data would be in a v3 stream", but that abstracted away so the
> higher level toolstack doesn't know or need to care.
> The missing parameter is "p.s. here are the things we were expecting but
> didn't get - you need to pick up the pieces".  For now, it is synonymous
> with "here is a v2 stream without CPUID data", but that won't be
> accurate in the future if/when new static data records get retrofitted.

Thanks for the explanation.

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.