[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 3/3] clang: don't define nocall


On 29/05/2020 09:31, Roger Pau Monné wrote:
On Fri, May 29, 2020 at 08:25:44AM +0100, Julien Grall wrote:
Hi Roger,

On 28/05/2020 15:40, Roger Pau Monne wrote:
Clang doesn't support attribute error, and the possible equivalents
like diagnose_if don't seem to work well in this case as they trigger
when when the function is not called (just by being used by the

OOI, could you share the diagnose_if change you tried?

I've sent a reduced version to the llvm-dev mailing list, because I
think the documentation should be fixed for diagnose_if. The email
with the example is at:



FWIW, using the deprecated attribute will also trigger the same
error/warning even when not calling the function from C.

I read the documentation before asking the code and I did wonder why diagnose_if wouldn't work.

I am guessing the behavior wasn't intended.


Julien Grall



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.