Re: [PATCH v10 07/12] xen: provide version information in hypfs

[Jürgen Groß <jgross@xxxxxxxx>]

On 29.05.20 10:34, Jan Beulich wrote:
> On 19.05.2020 09:21, Juergen Gross wrote:
> > @@ -373,6 +374,52 @@ void __init do_initcalls(void)
> >           (*call)();
> >   }
> >   
> > +#ifdef CONFIG_HYPFS
> > +static unsigned int __read_mostly major_version;
> > +static unsigned int __read_mostly minor_version;
> > +
> > +static HYPFS_DIR_INIT(buildinfo, "buildinfo");
> > +static HYPFS_DIR_INIT(compileinfo, "compileinfo");
> > +static HYPFS_DIR_INIT(version, "version");
> > +static HYPFS_UINT_INIT(major, "major", major_version);
> > +static HYPFS_UINT_INIT(minor, "minor", minor_version);
> These two lines fail to build with gcc 4.1 ("unknown field 'content'
> specified in initializer"), which I've deliberately tried as a last
> minute post-commit, pre-push check. I therefore reverted this change
> before pushing.
>
> Paul, Jürgen - please advise how to proceed, considering today's
> deadline. I'd accept pushing the rest of the series, if a fix for
> the issue will then still be permitted in later. Otherwise I'd have
> to wait for a fixed (incremental) version
The attached patch should fix this problem (assuming the anonymous
union is to blame).

Could you verify that, please?

In case the patch is fine, I'll resend the rest of the series with
that patch included, as there are adaptions in later patches needed.


Juergen

Attachment: 0001-xen-hypfs-make-struct-hypfs_entry_leaf-initializers-.patch
Description: Text Data