RE: [PATCH v6 2/5] block: consolidate blocksize properties consistency checks

[Paul Durrant <xadimgnik@xxxxxxxxx>]

> -----Original Message-----
> From: Roman Kagan <rvkagan@xxxxxxxxxxxxxx>
> Sent: 27 May 2020 13:45
> To: qemu-devel@xxxxxxxxxx
> Cc: Kevin Wolf <kwolf@xxxxxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx; Gerd 
> Hoffmann <kraxel@xxxxxxxxxx>;
> Daniel P. Berrangé <berrange@xxxxxxxxxx>; Paolo Bonzini 
> <pbonzini@xxxxxxxxxx>; Anthony Perard
> <anthony.perard@xxxxxxxxxx>; Laurent Vivier <laurent@xxxxxxxxx>; Max Reitz 
> <mreitz@xxxxxxxxxx>; qemu-
> block@xxxxxxxxxx; Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>; Eric Blake 
> <eblake@xxxxxxxxxx>; Paul
> Durrant <paul@xxxxxxx>; Fam Zheng <fam@xxxxxxxxxx>; John Snow 
> <jsnow@xxxxxxxxxx>; Michael S. Tsirkin
> <mst@xxxxxxxxxx>; Eduardo Habkost <ehabkost@xxxxxxxxxx>; Keith Busch 
> <kbusch@xxxxxxxxxx>; Stefano
> Stabellini <sstabellini@xxxxxxxxxx>; Stefan Hajnoczi <stefanha@xxxxxxxxxx>
> Subject: [PATCH v6 2/5] block: consolidate blocksize properties consistency 
> checks
> 
> Several block device properties related to blocksize configuration must
> be in certain relationship WRT each other: physical block must be no
> smaller than logical block; min_io_size, opt_io_size, and
> discard_granularity must be a multiple of a logical block.
> 
> To ensure these requirements are met, add corresponding consistency
> checks to blkconf_blocksizes, adjusting its signature to communicate
> possible error to the caller.  Also remove the now redundant consistency
> checks from the specific devices.
> 
> Signed-off-by: Roman Kagan <rvkagan@xxxxxxxxxxxxxx>

Reviewed-by: Paul Durrant <paul@xxxxxxx>