[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 06/15] x86_64/mm: introduce pl2e in paging_init

To: Hongyan Xia <hx242@xxxxxxx>
From: Jan Beulich <jbeulich@xxxxxxxx>
Date: Wed, 20 May 2020 11:35:59 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Roger Pau Monné <roger.pau@xxxxxxxxxx>, julien@xxxxxxx, Wei Liu <wl@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Delivery-date: Wed, 20 May 2020 09:36:14 +0000
List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 24.04.2020 16:08, Hongyan Xia wrote:
> From: Wei Liu <wei.liu2@xxxxxxxxxx>
> 
> Introduce pl2e so that we can use l2_ro_mpt to point to the page table
> itself.
> 
> No functional change.
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>

In principle I'm fine with the change, as a preparatory one for
the next patch. The description, however, suggests this is a
change for the sake of making a change: introducing a local
variable that's not really needed for anything.

Jan

Prev by Date: Re: [PATCH v2] x86: use POPCNT for hweight<N>() when available
Next by Date: Re: [PATCH v6 07/15] x86_64/mm: switch to new APIs in paging_init
Previous by thread: Re: [PATCH v6 03/15] x86/mm: rewrite virt_to_xen_l*e
Next by thread: Re: [PATCH v6 07/15] x86_64/mm: switch to new APIs in paging_init
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.