[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86: determine MXCSR mask in all cases

  • To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Mon, 18 May 2020 14:43:13 +0100
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Mon, 18 May 2020 13:43:23 +0000
  • Ironport-sdr: iPDJMvHDM8739jgWth+7bNACdGvlAPah29U/UnnktOeRjWJh3q0uiNGfw68V3DbPh54w8CVTeb SJ2bfr0+P2frQ2rNyRC+4d3Vy+yMe9+VmQAmGR2mQvQ5Unc2er8d3G/xob20P+0A41THAc6qSL Qs4dE2m+57XjpZMHLSBRZ/FzwZlew+OLXjw3Jh5FqvFZci64dpPY347WW5Jzv7oWXxrXe1y9Jk KZdqFgtvg/3p3oRgd/N7TPVO0Z/wGY8LTMYdzElq4cz+PEX1LoVe6tGpplr9Cx6UkAYO5WeOr9 WcQ=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 18/05/2020 14:16, Jan Beulich wrote:
> For its use(s) by the emulator to be correct in all cases, the filling
> of the variable needs to be independent of XSAVE availability. As
> there's no suitable function in i387.c to put the logic in, keep it in
> xstate_init(), arrange for the function to be called unconditionally,
> and pull the logic ahead of all return paths there.
> Fixes: 9a4496a35b20 ("x86emul: support {,V}{LD,ST}MXCSR")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.