[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/hvm: Fix shifting in stdvga_mem_read()

To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
From: Jan Beulich <jbeulich@xxxxxxxx>
Date: Mon, 18 May 2020 13:11:50 +0200
Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
Delivery-date: Mon, 18 May 2020 11:12:04 +0000
List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 16.05.2020 21:02, Andrew Cooper wrote:
> stdvga_mem_read() has a return type of uint8_t, which promotes to int rather
> than unsigned int.  Shifting by 24 may hit the sign bit.
> 
> Spotted by Coverity.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

References:
- [PATCH] x86/hvm: Fix shifting in stdvga_mem_read()
  - From: Andrew Cooper

Prev by Date: Re: [PATCH] x86/hvm: Fix memory leaks in hvm_copy_context_and_params()
Next by Date: [PATCH for-4.14 0/3] Remove the 1GB limitation on Rasberry Pi 4
Previous by thread: [PATCH] x86/hvm: Fix shifting in stdvga_mem_read()
Next by thread: [xen-unstable test] 150212: tolerable FAIL - PUSHED
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.