[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH 2/2] xen/build: use the correct kconfig makefile

  • To: Stewart Hildebrand <stewart.hildebrand@xxxxxxxxxxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Fri, 15 May 2020 15:51:50 +0100
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=anthony.perard@xxxxxxxxxx; spf=Pass smtp.mailfrom=anthony.perard@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx; dmarc=pass (p=none dis=none) d=citrix.com
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Doug Goldstein <cardoe@xxxxxxxxxx>
  • Delivery-date: Fri, 15 May 2020 14:52:07 +0000
  • Ironport-sdr: bZ1NkMZLB4UHhB5ve1Ln8dfMSqKtKNoWZ4U5AoJCA5HOqjdqZYjKaBY+cEpMdCgj/sHfA2zTpS e2W82+/7vM7yQVvjgL/gJafeezdiWJmRvtp7cO1eEEUc3V/aDo7zXaGHvO3Ww1Noz+psNiMy4K bQ3A6BuWSW9m+FRIB4a9t8Gk5C3uN8b4vv3kDI6rwtXJAVmxtRdSglvQmJlWTPi4uGUjWnTWfk LNeUYn1QJqhVFtjg5DRO/d3ggjcuzH3Pemz3LXufyfZ9ilhMqV/1VCix8L3OIFauCNwTm4WW6R IKM=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, May 12, 2020 at 01:52:06PM -0400, Stewart Hildebrand wrote:
> This resolves the following observed error:
> #
> # merged configuration written to .config (needs make)
> #
> make -f /path/to/xen/xen/../xen/Makefile olddefconfig
> make[2]: Entering directory '/path/to/xen/xen'
> make[2]: *** No rule to make target 'olddefconfig'.  Stop.
> make[2]: Leaving directory '/path/to/xen/xen'
> tools/kconfig/Makefile:95: recipe for target 'custom.config' failed

That commit message is kind of misleading, as the command run which
lead to the error isn't written. Could you expand the commit message to
include the problematic command ran? Something like:
    Running `make custom.config` fails with:

> Signed-off-by: Stewart Hildebrand <stewart.hildebrand@xxxxxxxxxxxxxxx>
> ---
> It's possible there are other places where the Makefile path will need
> to be changed. This just happened to be the one that failed for me.

The two other locations that calls back on the main Makefile aren't
usable by Xen, they would lead to another error anyway. So fixing the
only %.config is good enough.

> ---
>  xen/tools/kconfig/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/xen/tools/kconfig/Makefile b/xen/tools/kconfig/Makefile
> index fd37f4386a..f39521a0ed 100644
> --- a/xen/tools/kconfig/Makefile
> +++ b/xen/tools/kconfig/Makefile
> @@ -94,7 +94,7 @@ configfiles=$(wildcard $(srctree)/kernel/configs/$@ 
> $(srctree)/arch/$(SRCARCH)/c
>  %.config: $(obj)/conf
>       $(if $(call configfiles),, $(error No configuration exists for this 
> target on this architecture))
>       $(Q)$(CONFIG_SHELL) $(srctree)/tools/kconfig/merge_config.sh -m .config 
> $(configfiles)
> -     $(Q)$(MAKE) -f $(srctree)/Makefile olddefconfig
> +     $(Q)$(MAKE) -f $(srctree)/tools/kconfig/Makefile.kconfig olddefconfig

Well, the issue would be with $(srctree)/Makefile, but I don't think
that can be fixed right now. So that change is good for now.

With the commit message adjusted:
Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>


Anthony PERARD



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.