[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 20/21] libxl: Kill vchan-socket-proxy when cleaning up qmp

Jason Andryuk writes ("[PATCH v5 20/21] libxl: Kill vchan-socket-proxy when 
cleaning up qmp"):
> We need to kill the vchan-socket-proxy so we don't leak the daemonized
> processes.  libxl__stubdomain_is_linux_running works against the
> guest_domid, but the xenstore path is beneath the stubdomain.  This
> leads to the use of libxl_is_stubdom in addition to
> libxl__stubdomain_is_linux_running so that the stubdomain calls kill for
> the qmp-proxy

In theory maybe this patch should be folded into the one that
introduces the vchan proxy.  But since this whole mode of operation is
new, having a point in the history where it leaks these is OK I

Do others agree ?

For my part,

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

However, if possible maybe this patch could be moved to right after
the one which spawns the proxy ?




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.