[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] x86/guest: Fix assembler warnings with newer binutils

GAS of at least version 2.34 complains:

  hypercall_page.S: Assembler messages:
  hypercall_page.S:24: Warning: symbol 'HYPERCALL_set_trap_table' already has 
its type set
  hypercall_page.S:71: Warning: symbol 'HYPERCALL_arch_7' already has its type 

This is because the whole page is declared as STT_OBJECT, and then every
hypercall within it is declared as STT_FUNC.  As these are function-like and
in .text, retain the STT_FUNC type and drop STT_OBJECT.

Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CC: Jan Beulich <JBeulich@xxxxxxxx>
CC: Wei Liu <wl@xxxxxxx>
CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Alternative suggestions welcome.  I've got half a mind to strip the unused
hypercalls, as a large chunk of them are PV only and will never be used by a
PVH Xen.  This would also remove the existing alias between hypercall_page and
 xen/arch/x86/guest/xen/hypercall_page.S | 1 -
 1 file changed, 1 deletion(-)

diff --git a/xen/arch/x86/guest/xen/hypercall_page.S 
index 6485e9150e..9673846b7d 100644
--- a/xen/arch/x86/guest/xen/hypercall_page.S
+++ b/xen/arch/x86/guest/xen/hypercall_page.S
@@ -8,7 +8,6 @@
          /* Poisoned with `ret` for safety before hypercalls are set up. */
         .fill PAGE_SIZE, 1, 0xc3
-        .type hypercall_page, STT_OBJECT
         .size hypercall_page, PAGE_SIZE



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.