[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 01/16] x86/traps: Drop last_extable_addr

  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Mon, 11 May 2020 15:53:42 +0100
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@xxxxxxxxxx; spf=Pass smtp.mailfrom=Andrew.Cooper3@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx; dmarc=pass (p=none dis=none) d=citrix.com
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Mon, 11 May 2020 14:53:50 +0000
  • Ironport-sdr: 7R3ic9toiaykhYNmVUq9jQaGi4XMCpaOnFxHpaSGz+Q5uraBh92ojoMI/GBa8fp6ktx3KS3q6I VX2YCzOmW8BdsyH6KxiQIbj1HxkvXHG3HgQoE9UOZZl87w52w+2GBYf1WoklEXGfIW7mdfce3n 5k7GAViWwXONNYqcgFFC8jqknbofxoD60d+XFo/FZ9Y+lI6ku6R/Cy779iPNert22OP6wj02UV gSiIZ5I+60brbMMK4uMLhRP2wvEvXrbupBXMvp5C0NS89fd6HGQgIVWKkjW5WEgb+JAuflTRSy +AI=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 04/05/2020 13:44, Jan Beulich wrote:
> On 02.05.2020 00:58, Andrew Cooper wrote:
>> The only user of this facility is dom_crash_sync_extable() by passing 0 into
>> asm_domain_crash_synchronous().  The common error cases are already covered
>> with show_page_walk(), leaving only %ss/%fs selector/segment errors in the
>> compat case.
>> Point at dom_crash_sync_extable in the error message, which is about as good
>> as the error hints from other users of asm_domain_crash_synchronous(), and
>> drop last_extable_addr.
> While I'm not entirely opposed, I'd like you to clarify that you indeed
> mean to (mostly) revert your own improvement from 6 or 7 years back
> (commit 8e0da8c07f4f). I'm also surprised to find this as part of the
> series it's in - in what way does this logic get in the way of CET-SS?

It was part of the exception_fixup() cleanup.  The first 4 patches not
specifically related to CET-SS.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.