Re: [PATCH] x86/gen-cpuid: Distinguish default vs max in feature annotations

[Jan Beulich <jbeulich@xxxxxxxx>]

On 08.05.2020 17:27, Andrew Cooper wrote:
> @@ -133,9 +134,13 @@ def crunch_numbers(state):
>      state.hvm_shadow_def = state.pv_def | state.raw['S']
>      state.hvm_hap_def = state.hvm_shadow_def | state.raw['H']
>  
> +    # TODO: Ignore def/max split until the toolstack migration logic is fixed
>      state.pv_max = state.pv_def
>      state.hvm_shadow_max = state.hvm_shadow_def
>      state.hvm_hap_max = state.hvm_hap_def
> +    # state.pv_max = state.raw['A'] | state.raw['a']
> +    # state.hvm_shadow_max = state.pv_max | state.raw['S'] | state.raw['s']
> +    # state.hvm_hap_max = state.hvm_shadow_max | state.raw['H'] | 
> state.raw['h']

While in comment form it doesn't matter yet, for actually enabling
this it would seem to me to be more expressive as

    state.pv_max = state.pv_def | state.raw['a']
    state.hvm_shadow_max = state.hvm_shadow_def | state.pv_max | state.raw['s']
    state.hvm_hap_max = state.hvm_hap_def | state.hvm_shadow_max | 
state.raw['h']

Thoughts?

Jan