Re: [PATCH] x86/pv: Fix Clang build with !CONFIG_PV32

[Jan Beulich <jbeulich@xxxxxxxx>]

On 05.05.2020 17:05, Andrew Cooper wrote:
> On 05/05/2020 15:52, Jan Beulich wrote:
>> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments 
>> unless you have verified the sender and know the content is safe.
>>
>> On 05.05.2020 16:28, Andrew Cooper wrote:
>>> @@ -753,8 +751,9 @@ void load_system_tables(void)
>>>     _set_tssldt_desc(gdt + TSS_ENTRY, (unsigned long)tss,
>>>                      sizeof(*tss) - 1, SYS_DESC_tss_avail);
>>>     if ( IS_ENABLED(CONFIG_PV32) )
>>> -           _set_tssldt_desc(compat_gdt + TSS_ENTRY, (unsigned long)tss,
>>> -                            sizeof(*tss) - 1, SYS_DESC_tss_busy);
>>> +           _set_tssldt_desc(
>>> +                   this_cpu(compat_gdt) - FIRST_RESERVED_GDT_ENTRY + 
>>> TSS_ENTRY,
>>> +                   (unsigned long)tss, sizeof(*tss) - 1, 
>>> SYS_DESC_tss_busy);
>> Isn't indentation here off by 4 compared to what we
>> normally do with extremely large argument expressions?
> 
> No.  This is Linux style (therefore 8-space tabs), not Xen style (4 spaces).

Oh, right - din't pay attention at all to this being tabs, sorry.

Jan