Re: [PATCH v2 5/5] tools/libxc: make use of domain context SHARED_INFO record...

[Jan Beulich <jbeulich@xxxxxxxx>]

On 07.04.2020 19:38, Paul Durrant wrote:
> ... in the save/restore code.
> 
> This patch replaces direct mapping of the shared_info_frame (retrieved
> using XEN_DOMCTL_getdomaininfo) with save/load of the domain context
> SHARED_INFO record.
> 
> No modifications are made to the definition of the migration stream at
> this point. Subsequent patches will define a record in the libxc domain
> image format for passing domain context and convert the save/restore code
> to use that.
> 
> Signed-off-by: Paul Durrant <pdurrant@xxxxxxxxxx>
> ---
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Wei Liu <wl@xxxxxxx>
> 
> v2:
>  - Re-based (now making use of DOMAIN_SAVE_FLAG_IGNORE)
> ---
>  tools/libxc/xc_sr_common.h         |  7 +++-
>  tools/libxc/xc_sr_common_x86.c     | 59 ++++++++++++++++++++++++++++++
>  tools/libxc/xc_sr_common_x86.h     |  4 ++
>  tools/libxc/xc_sr_common_x86_pv.c  | 53 +++++++++++++++++++++++++++
>  tools/libxc/xc_sr_common_x86_pv.h  |  3 ++
>  tools/libxc/xc_sr_restore_x86_pv.c | 40 ++++++++------------
>  tools/libxc/xc_sr_save_x86_pv.c    | 26 ++-----------
>  tools/libxc/xg_save_restore.h      |  1 +
>  8 files changed, 144 insertions(+), 49 deletions(-)

The underlying interface being arch-independent, shouldn't at least
some of the new code go into other than xc_sr_*x86*?

Jan