Re: [PATCH 1/2] Fix undefined behaviour

[Artur Puzio <artur@xxxxxxxxxxxx>]

On 28.04.2020 10:10, Paul Durrant wrote:
>> -----Original Message-----
>> From: Grzegorz Uriasz <gorbak25@xxxxxxxxx>
>> Sent: 28 April 2020 07:29
>> To: qemu-devel@xxxxxxxxxx
>> Cc: Grzegorz Uriasz <gorbak25@xxxxxxxxx>; marmarek@xxxxxxxxxxxxxxxxxxxxxx; 
>> artur@xxxxxxxxxxxx;
>> jakub@xxxxxxxxxxx; j.nowak26@xxxxxxxxxxxxxxxxx; Stefano Stabellini 
>> <sstabellini@xxxxxxxxxx>; Anthony
>> Perard <anthony.perard@xxxxxxxxxx>; Paul Durrant <paul@xxxxxxx>; 
>> xen-devel@xxxxxxxxxxxxxxxxxxxx
>> Subject: [PATCH 1/2] Fix undefined behaviour
>>
>> Signed-off-by: Grzegorz Uriasz <gorbak25@xxxxxxxxx>
> I think we need more of a commit comment for both this and patch #2 to 
> explain why you are making the changes.
>
>   Paul 

I agree Grzegorz should improve the commit messages. In the mean time
see email with subject "[PATCH 0/2] Fix QEMU crashes when passing IGD to
a guest VM under XEN", it contains quite detailed explanation for both
"Fix undefined behaviour" and "Improve legacy vbios handling" patches.

Artur Puzio