[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/shadow: make sh_remove_write_access() helper HVM only

To: Jan Beulich <jbeulich@xxxxxxxx>
From: Tim Deegan <tim@xxxxxxx>
Date: Wed, 22 Apr 2020 07:48:09 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Delivery-date: Wed, 22 Apr 2020 06:48:12 +0000
List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

At 14:05 +0200 on 21 Apr (1587477956), Jan Beulich wrote:
> Despite the inline attribute at least some clang versions warn about
> trace_shadow_wrmap_bf() being unused in !HVM builds. Include the helper
> in the #ifdef region.
> 
> Fixes: 8b8d011ad868 ("x86/shadow: the guess_wrmap() hook is needed for HVM 
> only")
> Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Tim Deegan <tim@xxxxxxx>

References:
- [PATCH] x86/shadow: make sh_remove_write_access() helper HVM only
  - From: Jan Beulich

Prev by Date: Re: [PATCH v2 2/4] x86/shadow: sh_update_linear_entries() is a no-op for PV
Next by Date: Re: [PATCH v2 4/4] x86: adjustments to guest handle treatment
Previous by thread: Re: [PATCH] x86/shadow: make sh_remove_write_access() helper HVM only
Next by thread: [PATCH v3 0/2] x86: VM assist hypercall adjustments
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.