[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 08/11] x86/ucode/amd: Rename bufsize to size in cpu_request_microcode()


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Tue, 31 Mar 2020 15:43:02 +0100
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@xxxxxxxxxx; spf=Pass smtp.mailfrom=Andrew.Cooper3@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Tue, 31 Mar 2020 14:43:16 +0000
  • Ironport-sdr: ut3ilwmamlN3xwyygqWv9XHpyxF0X2O/NjIwQ6Ss0Ecoy88DNrOxxhgtDZheIn2ys37Ei/uSi6 qULAVUpu+DAVksG7zn+LtCpTEf0gN97fXyXt+gpam2vOEWpN8DsfLDHbdGLFhGIhbX0egp73FN dpwl7ZhUbFhjgvQSlvgpTrXdwHv3dtZkCZZNIkmuORXF1HP6TZi7mSxw2Nxcci6T0JstGtQZKf 5Hc0N8aZdeNsjZ4WwRK2p1/UY0wn/weHtS4ny+Gk/UgdZunQMvWvcE2QGRhTd7H4rtXF/5YHWa Dvk=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 31/03/2020 15:41, Jan Beulich wrote:
> On 31.03.2020 12:05, Andrew Cooper wrote:
>> To simplify future cleanup, rename this variable.
>>
>> No functional change.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
>
>> @@ -438,7 +437,7 @@ static struct microcode_patch 
>> *cpu_request_microcode(const void *buf,
>>      unsigned int cpu = smp_processor_id();
>>      const struct cpu_signature *sig = &per_cpu(cpu_sig, cpu);
>>  
>> -    if ( bufsize < 4 ||
>> +    if ( size < 4 ||
>>           *(const uint32_t *)buf != UCODE_MAGIC )
> Take the opportunity and put this on a single line?

I have actually done that in a later patch.

This was introduced in patch 1, so I'll fix there and rebase it
throughout the series.

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.