Re: [Xen-devel] [PATCH 09/17] xen/x86: Reduce the number of use of l*e_{from, get}_pfn()

[Julien Grall <julien@xxxxxxx>]

Hi Jan,

On 27/03/2020 10:52, Jan Beulich wrote:
> On 22.03.2020 17:14, julien@xxxxxxx wrote:
> > --- a/xen/arch/x86/mm.c
> > +++ b/xen/arch/x86/mm.c
> > @@ -1138,7 +1138,7 @@ static int
> >   get_page_from_l2e(
> >       l2_pgentry_t l2e, mfn_t l2mfn, struct domain *d, unsigned int flags)
> >   {
> > -    unsigned long mfn = l2e_get_pfn(l2e);
> > +    mfn_t mfn = l2e_get_mfn(l2e);
> >       int rc;
> >   
> >       if ( unlikely((l2e_get_flags(l2e) & L2_DISALLOW_MASK)) )
> > @@ -1150,7 +1150,7 @@ get_page_from_l2e(
> >   
> >       ASSERT(!(flags & PTF_preemptible));
> >   
> > -    rc = get_page_and_type_from_mfn(_mfn(mfn), PGT_l1_page_table, d, flags);
> > +    rc = get_page_and_type_from_mfn(mfn, PGT_l1_page_table, d, flags);
> To bring this better in line with the L3 and L4 counterparts,
> could you please drop the local variable instead? Then
I will do it.

> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Cheers,

--
Julien Grall