Re: [Xen-devel] [PATCH v2] SVM: Add union intstat_t for offset 68h in vmcb struct

[Pu Wen <puwen@xxxxxxxx>]

On 2020/3/25 18:30, Roger Pau Monné wrote:
> On Tue, Mar 24, 2020 at 06:37:26PM +0800, Pu Wen wrote:
> > diff --git a/xen/include/asm-x86/hvm/svm/vmcb.h 
> > b/xen/include/asm-x86/hvm/svm/vmcb.h
> > index b9e389d481..d8a3285752 100644
> > --- a/xen/include/asm-x86/hvm/svm/vmcb.h
> > +++ b/xen/include/asm-x86/hvm/svm/vmcb.h
> > @@ -316,6 +316,17 @@ typedef union
> >       uint64_t raw;
> >   } intinfo_t;
> >   
> > +typedef union
> > +{
> > +    struct
> > +    {
> > +        u64 intr_shadow:    1;
> > +        u64 guest_intr_mask:1;
> > +        u64 resvd:          62;
> Could you also use uint64_t for the fields, like you do below for
> raw?
Ok, thanks. Maybe bool for intr_shadow and guest_intr_mask is better?

--
Regards,
Pu Wen