Re: [Xen-devel] [PATCH v4 3/3] mm: add 'is_special_page' inline function...

[Jan Beulich <jbeulich@xxxxxxxx>]

On 18.03.2020 18:32, Paul Durrant wrote:
> From: Paul Durrant <pdurrant@xxxxxxxxxx>
> 
> ... to cover xenheap and PGC_extra pages.
> 
> PGC_extra pages are intended to hold data structures that are associated
> with a domain and may be mapped by that domain. They should not be treated
> as 'normal' guest pages (i.e. RAM or page tables). Hence, in many cases
> where code currently tests is_xen_heap_page() it should also check for
> the PGC_extra bit in 'count_info'.
> 
> This patch therefore defines is_special_page() to cover both cases and
> converts tests of is_xen_heap_page() (or open coded tests of PGC_xen_heap)
> to is_special_page() where the page is assigned to a domain.
> 
> Signed-off-by: Paul Durrant <paul@xxxxxxx>
> Acked-by: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

The implied ack here is on the assumption that ultimately the
per-domain ->xenpage_list will go away altogether, leaving us
without the currently resulting mix.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel