Re: [Xen-devel] [PATCH] xen-pciback: fix INTERRUPT_TYPE_* defines

[Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>]

On Thu, Mar 19, 2020 at 11:07:13AM -0400, Boris Ostrovsky wrote:
> 
> On 3/19/20 12:06 AM, Marek Marczykowski-Górecki wrote:
> > INTERRUPT_TYPE_NONE should be 0,
> 
> 
> Would
> 
>   return ret ?: INTERRUPT_TYPE_NONE
> 
> in xen_pcibk_get_interrupt_type() work?
> 
> 
> I think it's better not to tie macro name to a particular value.

I can do that too. But I'd change INTERRUPT_TYPE_NONE to 0 anyway, as
more logical value (as the value is a bitmask).

> -boris
> 
> 
> >   as it is assumed in
> > xen_pcibk_get_interrupt_type(). Fix the definition, and also shift other
> > values to not leave holes.
> > But also use INTERRUPT_TYPE_NONE in xen_pcibk_get_interrupt_type() to
> > avoid similar confusions in the future.
> > 
> > Fixes: 476878e4b2be ("xen-pciback: optionally allow interrupt enable flag 
> > writes")
> > Signed-off-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> > 

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel