|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] [xen-unstable test] 148685: regressions - trouble: fail/pass/starved
flight 148685 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/148685/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit1 7 xen-boot fail REGR. vs. 148611 test-amd64-amd64-dom0pvh-xl-intel 16 guest-localmigrate fail REGR. vs. 148611 test-armhf-armhf-xl-vhd 18 leak-check/check fail REGR. vs. 148611 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-rtds 18 guest-localmigrate/x10 fail like 148571 test-amd64-amd64-qemuu-nested-intel 17 debian-hvm-install/l1/l2 fail like 148611 test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail like 148611 test-armhf-armhf-libvirt 14 saverestore-support-check fail like 148611 test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail like 148611 test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail like 148611 test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop fail like 148611 test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail like 148611 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail like 148611 test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop fail like 148611 test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail like 148611 test-amd64-i386-libvirt 13 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 12 guest-start fail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 14 saverestore-support-check fail never pass test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass test-arm64-arm64-xl 13 migrate-support-check fail never pass test-arm64-arm64-xl 14 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 14 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 14 saverestore-support-check fail never pass test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2 fail never pass test-armhf-armhf-xl 13 migrate-support-check fail never pass test-armhf-armhf-xl 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 14 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 14 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 12 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 13 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 14 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 14 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 14 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 14 saverestore-support-check fail never pass test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop fail never pass test-amd64-amd64-dom0pvh-xl-amd 2 hosts-allocate starved n/a version targeted for testing: xen 1faa954df18733792c33b3f5b1b4de4662cfa892 baseline version: xen d094e95fb7c61c5f46d8e446b4bdc028438dea1c Last test of basis 148611 2020-03-16 01:51:12 Z 2 days Failing since 148636 2020-03-16 18:36:29 Z 1 days 3 attempts Testing same since 148685 2020-03-18 02:40:34 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> Jan Beulich <jbeulich@xxxxxxxx> Juergen Gross <jgross@xxxxxxxx> Julien Grall <jgrall@xxxxxxxxxx> Wei Liu <wl@xxxxxxx> jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd starved test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-amd64-pvgrub pass test-amd64-amd64-i386-pvgrub pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 1faa954df18733792c33b3f5b1b4de4662cfa892 Author: Jan Beulich <jbeulich@xxxxxxxx> Date: Tue Mar 17 16:20:08 2020 +0100 libfdt: fix undefined behaviour in _fdt_splice() Along the lines of commit d0b3ab0a0f46 ("libfdt: Fix undefined behaviour in fdt_offset_ptr()"), _fdt_splice() similarly may not use pointer arithmetic to do overflow checks. [upstream commit 73d6e9ecb4179b510408bc526240f829262df361] Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Acked-by: Julien Grall <jgrall@xxxxxxxxxx> commit 66fb1406568c7e582dbd5ffd8f3b8a8350146960 Author: David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> Date: Tue Mar 17 16:18:57 2020 +0100 libfdt: Fix undefined behaviour in fdt_offset_ptr() Using pointer arithmetic to generate a pointer outside a known object is, technically, undefined behaviour in C. Unfortunately, we were using that in fdt_offset_ptr() to detect overflows. To fix this we need to do our bounds / overflow checking on the offsets before constructing pointers from them. Reported-by: David Binderman <dcb314@xxxxxxxxxxx> Signed-off-by: David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> [upstream commit d0b3ab0a0f46ac929b4713da46f7fdcd893dd3bd] Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Acked-by: Julien Grall <jgrall@xxxxxxxxxx> commit 75c5fc0c7cefe50b6052c0b933186c4597ade70f Author: Jan Beulich <jbeulich@xxxxxxxx> Date: Tue Mar 17 16:18:08 2020 +0100 x86: reduce mce.h include dependencies Drop the public header #include as not needed by the header itself. Add one that was missing, and move all inside the inclusion guard. Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> commit 12f0c69f2709fdb0dd5ac408484a4a08d08705e9 Author: Jan Beulich <jbeulich@xxxxxxxx> Date: Tue Mar 17 16:17:20 2020 +0100 x86/HVM: reduce hvm.h include dependencies Drop #include-s not needed by the header itself, and add smaller scope ones instead. Put the ones needed into whichever other files actually need them. Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Reviewed-by: Paul Durrant <paul@xxxxxxx> Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> commit 169e8ec401c9485886a733de7f0191a5aae08a12 Author: Jan Beulich <jbeulich@xxxxxxxx> Date: Tue Mar 17 16:16:34 2020 +0100 x86/HVM: reduce io.h include dependencies Drop #include-s not needed by the header itself as well as one include of the header which isn't needed. Put the one needed into the file actually requiring it. Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> commit 2f661954e8512f08e58db3c285b5515fee414c95 Author: Jan Beulich <jbeulich@xxxxxxxx> Date: Tue Mar 17 16:15:49 2020 +0100 x86/HVM: reduce vlapic.h include dependencies Drop #include-s not needed by the header itself. Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> commit 79834d25f5cdfb1e14646c59720c53917c2713e6 Author: Jan Beulich <jbeulich@xxxxxxxx> Date: Tue Mar 17 16:14:57 2020 +0100 x86/HVM: reduce vioapic.h include dependencies Drop an #include not needed by the header itself. While verifying the header (now) builds standalone, I noticed an omission in a public header which gets taken care of here as well. Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> commit e593df9509b53ef26999f84e32e181b0f6e51e8f Author: Jan Beulich <jbeulich@xxxxxxxx> Date: Tue Mar 17 16:14:05 2020 +0100 x86/HVM: reduce vpic.h include dependencies Drop an #include not needed by the header itself. Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> commit bf66bb0573a3b7101cecd338bae422928bbf5c83 Author: Jan Beulich <jbeulich@xxxxxxxx> Date: Tue Mar 17 16:13:20 2020 +0100 x86/HVM: reduce vpt.h include dependencies Drop #include-s not needed by the header itself. Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> commit a37bf6ff1284e6897a6f51130f12905ec1351705 Author: Jan Beulich <jbeulich@xxxxxxxx> Date: Tue Mar 17 16:12:26 2020 +0100 x86/HVM: reduce vcpu.h include dependencies Drop #include-s not needed by the header itself. Put the ones needed into whichever other files actually need them. Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Reviewed-by: Paul Durrant <paul@xxxxxxx> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> commit 90d9a9884292eacce4f6fa9e54cbdeb3e0125c4d Author: Jan Beulich <jbeulich@xxxxxxxx> Date: Tue Mar 17 16:11:33 2020 +0100 x86/HVM: reduce domain.h include dependencies Drop #include-s not needed by the header itself. Put the ones needed into whichever other files actually need them. Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Reviewed-by: Paul Durrant <paul@xxxxxxx> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> commit 900cc67377b987f50e2b8c14f9fdac6ab508bd04 Author: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Date: Wed Mar 11 18:22:37 2020 +0000 x86/vvmx: Fix deadlock with MSR bitmap merging c/s c47984aabead "nvmx: implement support for MSR bitmaps" introduced a use of map_domain_page() which may get used in the middle of context switch. This is not safe, and causes Xen to deadlock on the mapcache lock: (XEN) Xen call trace: (XEN) [<ffff82d08022d6ae>] R _spin_lock+0x34/0x5e (XEN) [<ffff82d0803219d7>] F map_domain_page+0x250/0x527 (XEN) [<ffff82d080356332>] F do_page_fault+0x420/0x780 (XEN) [<ffff82d08038da3d>] F x86_64/entry.S#handle_exception_saved+0x68/0x94 (XEN) [<ffff82d08031729f>] F __find_next_zero_bit+0x28/0x69 (XEN) [<ffff82d080321a4d>] F map_domain_page+0x2c6/0x527 (XEN) [<ffff82d08029eeb2>] F nvmx_update_exec_control+0x1d7/0x323 (XEN) [<ffff82d080299f5a>] F vmx_update_cpu_exec_control+0x23/0x40 (XEN) [<ffff82d08029a3f7>] F arch/x86/hvm/vmx/vmx.c#vmx_ctxt_switch_from+0xb7/0x121 (XEN) [<ffff82d08031d796>] F arch/x86/domain.c#__context_switch+0x124/0x4a9 (XEN) [<ffff82d080320925>] F context_switch+0x154/0x62c (XEN) [<ffff82d080252f3e>] F common/sched/core.c#sched_context_switch+0x16a/0x175 (XEN) [<ffff82d080253877>] F common/sched/core.c#schedule+0x2ad/0x2bc (XEN) [<ffff82d08022cc97>] F common/softirq.c#__do_softirq+0xb7/0xc8 (XEN) [<ffff82d08022cd38>] F do_softirq+0x18/0x1a (XEN) [<ffff82d0802a2fbb>] F vmx_asm_do_vmentry+0x2b/0x30 Convert the domheap page into being a xenheap page. Fixes: c47984aabead - nvmx: implement support for MSR bitmaps Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx> Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx> commit 740ffb7fc7b9d1afa23bb38910913279c28aa991 Author: Jan Beulich <jbeulich@xxxxxxxx> Date: Mon Mar 16 17:32:41 2020 +0100 x86/APIC: reduce rounding errors in calculations Dividing by HZ/10 just to subsequently multiply by HZ again in all uses of the respective variable is pretty pointlessly introducing rounding (really: truncation) errors. While transforming the respective expressions it became apparent that "result" would be left unused except for its use as function return value. As the sole caller of the function doesn't look at the returned value, simply convert the function to have "void" return type. Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> commit a60bb682190f8c0147584fa58de47528cd866be3 Author: Jan Beulich <jbeulich@xxxxxxxx> Date: Mon Mar 16 17:31:35 2020 +0100 x86/time: reduce rounding errors in calculations Plain (unsigned) integer division simply truncates the results. The overall errors are smaller though if we use proper rounding. (Extend this to the purely cosmetic aspect of time.c's freq_string(), which before this change I've frequently observed to report e.g. NN.999MHz HPET clock speeds.) While adding the rounding logic, also switch to using an unsigned constant for the other, original half of bus_cycle's calculation. Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> commit 6b7860b5d04dfee4cbe0a64a4e9adc9832e2e73b Author: Juergen Gross <jgross@xxxxxxxx> Date: Mon Mar 16 11:27:29 2020 +0100 spinlocks: fix placement of preempt_[dis|en]able() In case Xen ever gains preemption support the spinlock coding's placement of preempt_disable() and preempt_enable() should be outside of the locked section. Signed-off-by: Juergen Gross <jgross@xxxxxxxx> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx> commit 12509bbeb9e386ca52ec46e23d1d540c6dc8d7d7 Author: Juergen Gross <jgross@xxxxxxxx> Date: Mon Mar 16 11:26:45 2020 +0100 rwlocks: call preempt_disable() when taking a rwlock Similar to spinlocks preemption should be disabled while holding a rwlock. Signed-off-by: Juergen Gross <jgross@xxxxxxxx> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx> commit 1946c33399ecc8dcad0938c4432b9e394eb78e17 Author: Jan Beulich <jbeulich@xxxxxxxx> Date: Mon Mar 16 11:26:10 2020 +0100 x86/APIC: adjust types and comments in calibrate_APIC_clock() First and foremost the comment talking about potential underflow being taken care of by using signed long type variables was true only on 32-bit, which we've not been supporting for quite some time. Drop the comment and change all involved types to unsigned. Take the opportunity and also replace bus_cycle's fixed width type. Additionally there's no point using an "arbitrary (but long enough) timeout" here. Just use the maximum possible value; Linux does so too, just as an additional data point. Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> commit efd09c771ead61fbe34161ae2250d4c77a2dcd36 Author: Jan Beulich <jbeulich@xxxxxxxx> Date: Mon Mar 16 11:25:45 2020 +0100 kconfig: expose all{yes,no}config targets Without having them at least at the xen/Makefile level they're (close to?) inaccessible. As I'm uncertain about their utility at the top level, I'm leaving it at that for now. Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Acked-by: Wei Liu <wl@xxxxxxx> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> commit b75b3c62fe4afe381c6f74a07f614c0b39fe2f5d Author: Jan Beulich <jbeulich@xxxxxxxx> Date: Mon Mar 16 11:24:29 2020 +0100 AMD/IOMMU: fix off-by-one in amd_iommu_get_paging_mode() callers amd_iommu_get_paging_mode() expects a count, not a "maximum possible" value. Prior to b4f042236ae0 dropping the reference, the use of our mis- named "max_page" in amd_iommu_domain_init() may have lead to such a misunderstanding. In an attempt to avoid such confusion in the future, rename the function's parameter and - while at it - convert it to an inline function. Also replace a literal 4 by an expression tying it to a wider use constant, just like amd_iommu_quarantine_init() does. Fixes: ea38867831da ("x86 / iommu: set up a scratch page in the quarantine domain") Fixes: b4f042236ae0 ("AMD/IOMMU: Cease using a dynamic height for the IOMMU pagetables") Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> (qemu changes not included) _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
 |
Lists.xenproject.org is hosted with RackSpace, monitoring our |