Re: [Xen-devel] [XEN PATCH v3 19/23] xen/build: Use if_changed_rules with %.o:%.c targets

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Wed, Mar 04, 2020 at 05:09:19PM +0100, Jan Beulich wrote:
> On 26.02.2020 12:33, Anthony PERARD wrote:
> > +define rule_cc_o_c
> > +    $(call cmd_and_record,cc_o_c)
> > +    $(call cmd,objcopy_fix_sym)
> 
> The machinery is resilient to a command (here: cmd_objcopy_fix_sym)
> not being defined, and will neither produce any undue output nor
> else incur any unnecessary overhead?

Yes, it's fine when cmd_objcopy_fix_sym isn't defined, nothing gets
printed on the console, and there is no error.

As for unnecessary overhead, I don't know. The macro still expand to
"@set -e;". But Linux uses that a lot (having undefined cmd_*), so I
guess it's not too bad.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel